Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_iothub & azurerm_iothub_dps: deprecate the sku.tier property #5382

Merged
merged 5 commits into from
Jan 14, 2020

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jan 12, 2020

partially addresses #1500

@katbyte katbyte added this to the v1.41.0 milestone Jan 12, 2020
@katbyte katbyte requested a review from a team January 12, 2020 23:58
@katbyte katbyte changed the title azurerm_iothub: deprecate the sku.tier property azurerm_iothub & azurerm_iothub_dps: deprecate the sku.tier property Jan 12, 2020
Copy link
Contributor

@tracypholmes tracypholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WodansSon
Copy link
Collaborator

Should this be flattened to a sku_name?

For example:

  sku_name = "S_1"

Instead of:

sku { 
    name     = "S1" 
    capacity = "1" 
}

WDYT?

@tombuildsstuff tombuildsstuff modified the milestones: v1.41.0, v1.42.0 Jan 14, 2020
@katbyte katbyte modified the milestones: v1.42.0, v1.41.0 Jan 14, 2020
@katbyte katbyte merged commit 2db030b into master Jan 14, 2020
@katbyte katbyte deleted the kt/fixsku-iothub branch January 14, 2020 19:39
katbyte added a commit that referenced this pull request Jan 14, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.41.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants