Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: data source for PostgreSQL #4732

Merged

Conversation

booyaa
Copy link
Contributor

@booyaa booyaa commented Oct 26, 2019

Status: I've got to finish the documentation.

Questions for reviewers:

  • In myTestAccDataSourceAzureRMPPostgreSqlServer_basic test, I've hard coded to use version 9.5, would you prefer I create basic tests for all versions supported?
  • Do I need to commit my go.sum?

Closes #4662

@ghost ghost added the size/M label Oct 26, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @booyaa

Thanks for this PR :)

Taking a look through this is looking good if we can fix up the minor comments this otherwise LGTM 👍.

To answer your questions:

In myTestAccDataSourceAzureRMPPostgreSqlServer_basic test, I've hard coded to use version 9.5, would you prefer I create basic tests for all versions supported?

That's fine, the response would be the same for all the versions so we're good here 👍

Do I need to commit my go.sum?

Not in this instance - since there's no changes to the vendored files. Likely your editor has been working against a slightly more up to date version of the Azure SDK for Go than we're using rather than the vendored SDK; but that's fine.

Thanks!

azurerm/data_source_postgresql_server.go Show resolved Hide resolved
website/azurerm.erb Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v1.36.0 milestone Oct 28, 2019
@tombuildsstuff tombuildsstuff modified the milestones: v1.36.0, v1.37.0 Oct 28, 2019
booyaa and others added 2 commits October 28, 2019 07:48
@booyaa
Copy link
Contributor Author

booyaa commented Oct 28, 2019

Thanks for the feedback @tombuildsstuff updated as per comments :)

@ghost ghost removed the waiting-response label Oct 28, 2019
@booyaa
Copy link
Contributor Author

booyaa commented Oct 28, 2019

it looks like tflint is failing, that's probably from me just accepting the suggested changes. I'll pull the code down and fix the errors.

@tombuildsstuff
Copy link
Contributor

Test passes:

Screenshot 2019-10-28 at 09 49 25

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing those changes @booyaa this now LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 70b8565 into hashicorp:master Oct 28, 2019
@tombuildsstuff tombuildsstuff modified the milestones: v1.37.0, v1.36.0 Oct 28, 2019
tombuildsstuff added a commit that referenced this pull request Oct 28, 2019
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Source for azurerm_postgresql_server
2 participants