Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_private_dns_ptr_record - new resource type (#4691) #4703

Merged
merged 9 commits into from
Oct 31, 2019

Conversation

phires
Copy link
Contributor

@phires phires commented Oct 24, 2019

Fixes issue #4691 (private_dns_zone does not support PTR records)

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @phires

Thanks for this PR :)

Taking a look through this is looking good - if we can fix up the minor issues (and the tests pass) then this otherwise LGTM 👍

Thanks!

azurerm/resource_arm_private_dns_ptr_record.go Outdated Show resolved Hide resolved
azurerm/resource_arm_private_dns_ptr_record.go Outdated Show resolved Hide resolved
azurerm/resource_arm_private_dns_ptr_record.go Outdated Show resolved Hide resolved
website/docs/r/private_dns_ptr_record.html.markdown Outdated Show resolved Hide resolved
website/docs/r/private_dns_ptr_record.html.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @phires

Thanks for pushing those changes - taking a look through aside from a missing sidebar link this otherwise LGTM 👍

Thanks!

Manages a Private DNS PTR Record.
---

# azurerm_private_dns_ptr_record
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-10-31 at 13 44 59

@tombuildsstuff tombuildsstuff merged commit b8562d1 into hashicorp:master Oct 31, 2019
tombuildsstuff added a commit that referenced this pull request Oct 31, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants