Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/postgresql_server: support storage auto-grow #4220

Merged
merged 3 commits into from
Sep 3, 2019

Conversation

evenh
Copy link
Contributor

@evenh evenh commented Sep 3, 2019

Add support for Azure PostgreSQL storage auto-grow. It went into GA on
June 26th 2019.

It is enabled by default, to conform with the behaviour described in
the Azure CLI docs .

This resolves #3885

Add support for Azure PostgreSQL storage auto-grow. It went into GA on
June 26th 2019.

It is enabled by default, to conform with the behaviour described in
the Azure CLI docs .

This resolves hashicorp#3885
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @evenh

Thanks for this PR - taking a look I've left a couple of comments inline but this otherwise LGTM 👍

Thanks!

azurerm/resource_arm_postgresql_server.go Outdated Show resolved Hide resolved
azurerm/resource_arm_postgresql_server.go Outdated Show resolved Hide resolved
@evenh
Copy link
Contributor Author

evenh commented Sep 3, 2019

Thanks for the quick review @tombuildsstuff. Should be fixed now :-)

@ghost ghost removed the waiting-response label Sep 3, 2019
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-09-03 at 14 31 36

(ignore the Travis error, this is because Apache's Git server is down)

@tombuildsstuff tombuildsstuff merged commit be7690f into hashicorp:master Sep 3, 2019
tombuildsstuff added a commit that referenced this pull request Sep 3, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Feature for azure postgreSQL
2 participants