Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_share_directory Allow uppercase characters #4178

Merged
merged 3 commits into from
Aug 28, 2019
Merged

azurerm_storage_share_directory Allow uppercase characters #4178

merged 3 commits into from
Aug 28, 2019

Conversation

nexxai
Copy link
Contributor

@nexxai nexxai commented Aug 28, 2019

Fixes #4165

@ghost ghost added the size/XS label Aug 28, 2019
@nexxai nexxai changed the title Initial commit azurerm_storage_share_directory Allow uppercase characters Aug 28, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @nexxai!

Overall this looks good, however could we add a acc test with uppercase to validate the API accepts uppercase? thanks!

@katbyte katbyte added this to the v1.34.0 milestone Aug 28, 2019
@ghost ghost added size/S and removed size/XS labels Aug 28, 2019
@nexxai
Copy link
Contributor Author

nexxai commented Aug 28, 2019

Overall this looks good, however could we add a acc test with uppercase to validate the API accepts uppercase? thanks!

TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMStorageShareDirectory_uppercase -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMStorageShareDirectory_uppercase
=== PAUSE TestAccAzureRMStorageShareDirectory_uppercase
=== CONT  TestAccAzureRMStorageShareDirectory_uppercase
--- PASS: TestAccAzureRMStorageShareDirectory_uppercase (187.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	190.407s

@ghost ghost removed the waiting-response label Aug 28, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nexxai

Thanks for pushing those changes - this LGTM 👍

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review August 28, 2019 21:01

dismissing since changes have been pushed

@tombuildsstuff tombuildsstuff merged commit 2010a2a into hashicorp:master Aug 28, 2019
tombuildsstuff added a commit that referenced this pull request Aug 28, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant create azurerm_storage_share_directory with any upper-case
3 participants