Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Service Fabric Cluster Template #4174

Closed
markti opened this issue Aug 28, 2019 · 3 comments
Closed

Example Service Fabric Cluster Template #4174

markti opened this issue Aug 28, 2019 · 3 comments

Comments

@markti
Copy link
Contributor

markti commented Aug 28, 2019

Description

A working example should be provided of using this resource type "azurerm_service_fabric_cluster".

Without an equivalent sample to the ARM template this terraform resource is completely pointless and a red herring. I see several issues (all closed) reporting the resource doesn't work and all responses pointing back to "in theory it does...but go figure it out, test it for us, and let us know if it actually works".

This is unacceptable.

@tombuildsstuff
Copy link
Contributor

hi @markti

Thanks for opening this issue.

The azurerm_service_fabric_cluster resource in Terraform provisions a Service Fabric Cluster - but doesn't provision/configure any nodes since that's additional configuration required on top of this resource (as is the case when provisioning an ARM Template). Instead Nodes for a Service Fabric Cluster need to be provisioned and managed separately - using a Virtual Machine Scale Set (to provision the instances) and an associated Virtual Machine Extension (to configure the Service Fabric Agent).

Taking a look at the Terraform Registry it appears there's a module for this on the Terraform Registry - which provisions a Linux Virtual Machine Scale Set with the Service Fabric Agent which I believe should help here.

Whilst I can appreciate it's frustrating that there isn't an example of this in the ./examples folder in the repository - if this doesn't work for you since the configuration for the Virtual Machine Extension is a 1:1 mapping from the ARM Template it should be possible to map this to Terraform. We're currently focused on the tasks required for 2.0 and as such we're unfortunately not going to be able to add examples of both Linux and Windows nodes in the short-term, but this is something we should do at some point, in particular we're always happy to add examples to the ./examples folder if someone gets to that before we do :)

It's worth noting that the next version of Service Fabric - Service Fabric Mesh - provisions and manages the nodes for you such that this would be possible using native Terraform Resources (which is being tracked in #2486) rather than provisioning these yourself - however at the time of writing we've not gotten to this yet.

Since I believe the module on the Terraform Registry should solve this issue, I'm going to close this issue for the moment; but please let us know if that (or mapping the Extension from the ARM Template linked above) doesn't solve your issue and we'll take another look.

Thanks!

@markti
Copy link
Contributor Author

markti commented Aug 29, 2019

Very diplomatic response. Sorry, yes just letting out a bit of frustration.

I just don't see how somebody "ships" a Terraform resource for "azurerm_service_fabric_cluster" without actually seeing if they can provision even a simple one node cluster with it and then dump that into the './examples' folder.

I am using the Actor Framework so I don't think that works with Service Mesh, right? I also need HIPAA compliance. Hence, why I need Service Fabric Cluster.

I am reverse engineering my ARM template here. https://github.com/markti/terraform-servicefabric-cluster.

Also I saw that @steve-hawkins mentioned he had spent several months building some Terraform templates. Steve if you're out there please have mercy on us and share :)

@ghost
Copy link

ghost commented Sep 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants