Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure Lighthouse / Azure Delegated Resource Management #3941

Closed
richeney opened this issue Jul 26, 2019 · 6 comments
Closed
Milestone

Comments

@richeney
Copy link
Contributor

richeney commented Jul 26, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add support for Azure Lighthouse, announced at Inspire 2019.

Many multi cloud partners are standardising on Terraform for customer deployments, and Lighthouse will be the default way to set up authorisations for service providers to gain the correct access, visibility and recognition in customer tenancies.

New or Affected Resource(s)

The new AzureRM provider, Microsoft.ManagedServices, provides two new types,

These are the Azure Delegated Resource Management calls.

Suggested Terraform resources to directly match:

  • azurerm_registration_assignments
  • azurerm_registration_definitions

Alternatively (or if synonyms are supported) then

  • azurerm_lighthouse_assignments
  • azurerm_lighthouse_definitions

Also data sources to match.

Potential Terraform Configuration

# To be defined, but similar to the role assignments bar argument / attribute differences.

References

Blog Posts

Video

Documentation

ARM Templates

@RickB-2840
Copy link
Contributor

I think it sounds like a good idea. I've only just learned of the existence of Lighthouse, but I've been reading about about it for a few hours and I can foresee a use case that's not about ongoing managed services, but about consulting - cloud architecture and security assessments in which Terraform compatibility would facilitate deployment of a proof of concept in the consulting client's cloud estate. We typically recommend clients adopt Terraform, and this might make it easier for us to do that.

@Humoiz
Copy link
Contributor

Humoiz commented Apr 14, 2020

I am working on this feature now. I should be submitting the PR by next week.

@lukiffer
Copy link
Contributor

This is a really useful feature for us as an MSP who manages our customer environments with Terraform.

Based on PR comments, it appears that it's been deferred pending an internal discussion surrounding CI/testability. Would be interested to see how that unfolds, but I'm also curious as to the actual likelihood of the CI issues being resolved in time for the tagged milestones.

Totally understand it may not be a high priority; I'm just trying to gauge the level of effort we should put into looking for interim solutions, or if we should just wait it out and import state after the fact.

@jackofallops jackofallops added this to the v2.28.0 milestone Sep 16, 2020
@jackofallops
Copy link
Member

Closing as addressed by merge of #6560, due to be released in v2.28.0 of the provider.

@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 2.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants