Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating identity on app_service_slot without recreating the resource #3702

Merged
merged 4 commits into from
Jun 27, 2019

Conversation

maxbog
Copy link
Contributor

@maxbog maxbog commented Jun 19, 2019

The main change to allow updating the identity was to refactor Create/Update functions into a single one to avoid copy-pasted code.

@ghost ghost added the size/M label Jun 19, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maxbog,

This LGTM aside from one question I've left inline about client_affinity_enabled, it appears you are setting it twice?

Enabled: utils.Bool(enabled),
HTTPSOnly: utils.Bool(httpsOnly),
SiteConfig: &siteConfig,
ClientAffinityEnabled: &affinity,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are setting this below, what's the reasoning behind adding it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I'll remove the assignment here

@maxbog maxbog force-pushed the f/app_service_slot_identity branch from 60ec6bd to f03f052 Compare June 27, 2019 11:04
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxbog,

I hope you don't mind but i swapped where it was being set as otherwise updates to the value were not registering. Now LGTM 👍

@katbyte katbyte added this to the v1.31.0 milestone Jun 27, 2019
@katbyte katbyte merged commit 8c42533 into hashicorp:master Jun 27, 2019
katbyte added a commit that referenced this pull request Jun 27, 2019
@ghost
Copy link

ghost commented Jun 28, 2019

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label Jun 28, 2019
@ghost
Copy link

ghost commented Jul 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants