Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note added for forced casing at runtime. #3695

Merged
merged 4 commits into from
Jun 24, 2019
Merged

Conversation

jblose-old
Copy link
Contributor

While working with the Azure MySQL PaaS it was identified that the name of the resource was forced to lower case in Azure at apply time; If uppercase letters were used in the Terraform Plan it was immediately out-of-date once applied and flagged the freshly created resource Destroy/Create at next planning.

While working with the Azure MySQL PaaS it was identified that the `name` of the resource was forced to lower case in Azure at apply time; If uppercase letters were used in the Terraform Plan it was immediately out-of-date once applied and flagged the freshly created resource Destroy/Create at next `planning`.
@katbyte katbyte self-assigned this Jun 20, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jblose,

Thanks for bringing this to our attention. I think a better change then updating the docs might be to change the resource to prevent uppercase characters for the server name? That way users who don't see the docs won't get tripped up. What do you think?

@jblose-old
Copy link
Contributor Author

@katbyte Thank you for following up on the PR. That works for me, correcting the provider over the documentation is the right way to go long term.

I may try and report it on the Azure project as well since "normally" when attempting to name something incorrectly Azure returns an Error Code = 400 with some flavor of Exception so the implementer understands something is incorrect versus quietly being helpful.

@ghost ghost removed the waiting-response label Jun 20, 2019
@ghost ghost added size/S and removed size/XS labels Jun 24, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jblose,

Hope you don't mind but i've pushed those changes to get this merged 🙂

@katbyte katbyte merged commit 1af6395 into hashicorp:master Jun 24, 2019
katbyte added a commit that referenced this pull request Jun 24, 2019
@jblose-old
Copy link
Contributor Author

@jblose,

Hope you don't mind but i've pushed those changes to get this merged

No worries at all and thank you, I was hoping to get around to it this past weekend and ended up sidetracked on another project. Keep fighting the good fight!

@ghost
Copy link

ghost commented Jun 28, 2019

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 25, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants