Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service_slot: Add site_credential attribute export #3444

Merged
merged 1 commit into from
May 15, 2019

Conversation

emilpalsson
Copy link
Contributor

A feature we're missing. Also requested in for example #1439.

Tested and working. However I added no automated tests since it's just a new export (and other exports are not tested). Tell me if you want me to add a test, and if so, if you want me to add a new test step or if I should simply add it to an existing test (e.g. TestAccAzureRMAppServiceSlot_basic).

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @emilpalsson

Thanks for this PR - taking a look through this LGTM 👍

Thanks!

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-05-15 at 16 02 23

@tombuildsstuff tombuildsstuff merged commit 5702870 into hashicorp:master May 15, 2019
tombuildsstuff added a commit that referenced this pull request May 15, 2019
@ghost
Copy link

ghost commented May 17, 2019

This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 15, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants