Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Provider-Level "Global" Tags #3420

Closed
JustinGrote opened this issue May 11, 2019 · 2 comments
Closed

Feature Request: Provider-Level "Global" Tags #3420

JustinGrote opened this issue May 11, 2019 · 2 comments

Comments

@JustinGrote
Copy link

JustinGrote commented May 11, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Implement hashicorp/terraform#2283 (comment) to enable global tags to be defined for a terraform configuration. I'd like to be able to tag that a resource was deployed with terraform, and where it was deployed from, without having to specify tag blocks on every single resource.

Tags specified in the provider block should merge with ones specified in resource blocks, with resource block tags overriding what is specified globally.

New or Affected Resource(s)

  • azurerm provider

Potential Terraform Configuration

provider "azurerm" {
  global_tags = {
    terraform = "true"
    terraform_version = "11.1"
    terraform_statefilepath = "https://..../terraform.tfstate"
  }
}

References

@tombuildsstuff
Copy link
Contributor

hey @JustinGrote

Thanks for opening this issue :)

Taking a look into this, whilst I can see the potential use-case for this unfortunately not all resources in Azure use a Dictionary/Key-Value Pair as Tags - some resources instead use an array of strings (e.g. ["foo", "bar"]. Whilst it could be possible to work around this, for example by using Key=Value for the items requiring a list of strings, unfortunately that's not going to work for everybody. As such whilst I can see the benefit to this idea, unfortunately I don't believe this approach would work in the Azure Provider at this time and as such I'm going to close this feature request for the moment.

Thanks!

@ghost
Copy link

ghost commented Jun 12, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants