[Storage Account] dfs, web endpoints, file secondary endpoint

[Lucretius]

Resolves #3082

I also noticed that the new API version provided a way to get the secondary File endpoints, so that has been added as well.

[katbyte]

Hi @Lucretius,

Thank you for the PR, this LGTM aside from i wonder if it would be helpful to write a helper function to manage some of the repetition in the code? WDYT?

[katbyte]

I wonder if it would be worthwhile to add a helper function to this file 🤔

if secondary != nil {
  webEndpoint, webHost err = parseEndPoint(secondary.Web)
  if err != nil { return err }
}

[Lucretius]

Yeah, I can refactor to add one in.

[Lucretius]

I've added a helper function to remove most of the duplication.

[katbyte]

Thanks for that change @Lucretius! looks much better now, but i believe there is a bug as the tests are failing with:

Test ended in panic.

------- Stdout: -------
=== RUN   TestAccAzureRMStorageAccount_blobConnectionString
=== PAUSE TestAccAzureRMStorageAccount_blobConnectionString
=== CONT  TestAccAzureRMStorageAccount_blobConnectionString

------- Stderr: -------
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2138e86]

goroutine 187 [running]:
github.com/terraform-providers/terraform-provider-azurerm/azurerm.flattenAndSetAzureRmStorageAccountSecondaryEndpoints(0xc000582770, 0x0, 0x1e, 0x2660ce0)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/resource_arm_storage_account.go:1112 +0x26
github.com/terraform-providers/terraform-provider-azurerm/azurerm.resourceArmStorageAccountRead(0xc000582770, 0x29e6a40, 0xc00081ea80, 0x2, 0x2)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/resource_arm_storage_account.go:788 +0xe52
github.com/terraform-providers/terraform-provider-azurerm/azurerm.resourceArmStorageAccountCreate(0xc000582770, 0x29e6a40, 0xc00081ea80, 0xc000582770, 0x0)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/resource_arm_storage_account.go:530 +0x113c
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/helper/schema.(*Resource).Apply(0xc0000eef50, 0xc0004f85a0, 0xc000af1020, 0x29e6a40, 0xc00081ea80, 0xc000719701, 0x3e, 0x0)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/helper/schema/resource.go:225 +0x351
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/helper/schema.(*Provider).Apply(0xc00029ed90, 0xc0000b7f90, 0xc0004f85a0, 0xc000af1020, 0x1, 0x481593, 0x0)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/helper/schema/provider.go:283 +0x9c
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform.(*EvalApply).Eval(0xc000af2ac0, 0x2f39ec0, 0xc00028dee0, 0x2, 0x2, 0x2a1f451, 0x4)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform/eval_apply.go:57 +0x226
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform.EvalRaw(0x2ef9620, 0xc000af2ac0, 0x2f39ec0, 0xc00028dee0, 0x0, 0x0, 0x0, 0x0)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform/eval.go:53 +0x156
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform.(*EvalSequence).Eval(0xc000af03e0, 0x2f39ec0, 0xc00028dee0, 0x2, 0x2, 0x2a1f451, 0x4)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform/eval_sequence.go:14 +0x9c
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform.EvalRaw(0x2ef9b60, 0xc000af03e0, 0x2f39ec0, 0xc00028dee0, 0x26e2720, 0x4b54342, 0x2660ce0, 0xc00089de10)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform/eval.go:53 +0x156
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform.Eval(0x2ef9b60, 0xc000af03e0, 0x2f39ec0, 0xc00028dee0, 0xc000af03e0, 0x2ef9b60, 0xc000af03e0, 0x2c66c00)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform/eval.go:34 +0x4d
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform.(*Graph).walk.func1(0x297afa0, 0xc0006a9710, 0x0, 0x0)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform/graph.go:126 +0xc45
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/dag.(*Walker).walkVertex(0xc000244310, 0x297afa0, 0xc0006a9710, 0xc00055a840)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/dag/walk.go:387 +0x367
created by github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/dag.(*Walker).Update
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/dag/walk.go:310 +0x986

[Lucretius]

@katbyte turns out that I shouldn't pass both secondary and secondary.Blob (or any subproperty) into the function when the property itself could potentially be nil! I added nil checks to both the primary and secondary and ran the previously failing acceptance test to verify.

dismissing since changes have been pushed

[tombuildsstuff]

Ignoring a known (existing) test failure, the tests pass:

[tombuildsstuff]

LGTM - thanks for this @Lucretius

[ghost]

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!