Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKS with VMSS #2900

Closed
epa095 opened this issue Feb 15, 2019 · 11 comments
Closed

AKS with VMSS #2900

epa095 opened this issue Feb 15, 2019 · 11 comments

Comments

@epa095
Copy link

epa095 commented Feb 15, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

az can create aks clusters with virtual scale sets enabled by --enable-vmss, and we would like to be able to do the same in terraform. VMSS is a requirement for node autoscaling, which is cool.

New or Affected Resource(s)

  • azurerm_kubernetes_cluster
@Lucretius
Copy link
Contributor

It looks like the new version of the SDK contains the necessary autoscaling configuration properties so this can be done with a bump to the containerservice API version being used.

@tombuildsstuff
Copy link
Contributor

@Lucretius the new version of the SDK being the SDK version or the API Version?

@Lucretius
Copy link
Contributor

Sorry, the new version of the API within the existing SDK. See here

@tombuildsstuff
Copy link
Contributor

@Lucretius looks like this would require bumping the Azure SDK too, we're currently using v25.1.0 where that API version isn't available: https://github.com/Azure/azure-sdk-for-go/tree/v25.1.0/services/containerservice/mgmt

@djsly
Copy link
Contributor

djsly commented Mar 25, 2019

I was looking at the same thing.

https://github.com/Azure/azure-sdk-for-go/tree/v26.5.0/services/containerservice/mgmt/2019-02-01/containerservice

comes with >= v26.5.0

@tombuildsstuff do you need to track the bump of the sdk in a separate issues / PR

@tombuildsstuff
Copy link
Contributor

@djsly sorry I meant to open a PR for the SDK upgrade last week (but it dropped off my radar) - let me do that now

@tombuildsstuff
Copy link
Contributor

@djsly PR to update the SDK: #3126

@landro
Copy link

landro commented May 3, 2019

Please also remember adding availability zone support while enabling vmss.

Availability zones are currently supported in the go SDK

	// AvailabilityZones - (PREVIEW) Availability zones for nodes. Must use VirtualMachineScaleSets AgentPoolType.
AvailabilityZones *[]string `json:"availabilityZones,omitempty"`

References

https://github.com/Azure/azure-sdk-for-go/blob/master/services/containerservice/mgmt/2019-04-30/containerservice/models.go

https://github.com/Azure/azure-cli-extensions/tree/master/src/aks-preview#enable-vmss-for-new-cluster-with-availability-zone-feature

@epa095
Copy link
Author

epa095 commented May 19, 2019

I guess this can be closed now that #3422 is merged @dominik-lekse?

@dominik-lekse
Copy link
Contributor

@epa095 @tombuildsstuff Yes, this feature is in the latest 1.28.0 release and the issue can be closed.

@epa095 epa095 closed this as completed May 20, 2019
@tombuildsstuff tombuildsstuff modified the milestones: v1.29.0, v1.28.0 May 21, 2019
@ghost
Copy link

ghost commented Jun 19, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants