Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark maxTasksPerNode as forcenew #2856

Merged

Conversation

stuartleeks
Copy link
Contributor

The maxTasksPerNode cannot be changed once a Batch pool has been created
so marking as ForceNew to require re-creating the pool

The maxTasksPerNode cannot be changed once a Batch pool has been created
so marking as ForceNew to require re-creating the pool
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @stuartleeks

@tombuildsstuff tombuildsstuff added this to the 1.23.0 milestone Feb 8, 2019
katbyte
katbyte previously requested changes Feb 8, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @stuartleeks,

LGTM aside from could the documentation be updated to reflect this?

@ghost ghost added the documentation label Feb 14, 2019
@tombuildsstuff
Copy link
Contributor

hey @stuartleeks

Thanks again for this PR :)

I hope you don't mind but I've pushed a commit to update the documentation so that we can get this merged 👍

Thanks!

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review February 14, 2019 21:50

dismissing since resolved

@stuartleeks
Copy link
Contributor Author

Thank you! It was on my list but unfortunately I didn't get chance to look at it this week.

@tombuildsstuff tombuildsstuff merged commit 94fac66 into hashicorp:master Feb 14, 2019
tombuildsstuff added a commit that referenced this pull request Feb 14, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants