Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_data_factory_linked_service_* rename data_factory_name to data_factory_id #14492

Merged
merged 4 commits into from
Dec 7, 2021
Merged

azurerm_data_factory_linked_service_* rename data_factory_name to data_factory_id #14492

merged 4 commits into from
Dec 7, 2021

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Dec 6, 2021 •
edited
Loading

image

@stephybun stephybun marked this pull request as ready for review December 6, 2021 12:28
@stephybun stephybun requested a review from a team December 6, 2021 12:28
manicminer
manicminer suggested changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stephybun, this mostly LGTM. Just a minor suggestion on the deprecation wording in the schema, and I think we should also retain at least one test for each that covers the data_factory_name property? (e.g. TestAccDataFactoryLinkedServiceAzureBlobStorage_deprecated)

internal/services/datafactory/data_factory_linked_service_azure_blob_storage_resource.go Outdated
ForceNew: true,
ValidateFunc: validate.DataFactoryName(),
Deprecated: "Deprecated in favour of `data_factory_id`",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest an explicit message about when this would be removed

Suggested change
Deprecated: "Deprecated in favour of `data_factory_id`",
Deprecated: "`data_factory_name` is deprecated in favour of `data_factory_id` and will be removed in version 3.0 of the AzureRM provider",

internal/services/datafactory/data_factory_linked_service_azure_databricks_resource.go Outdated
ForceNew: true,
ValidateFunc: validate.DataFactoryName(),
Deprecated: "Deprecated in favour of `data_factory_id`",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

@stephybun
Copy link
Member Author

Thanks for the suggestions @manicminer. The deprecation messages have been updated. Regarding the tests I left data_factory_name in the terraform config for the second update that's done in the update acceptance tests which nearly all of them have.

manicminer
manicminer approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦈

@stephybun stephybun merged commit c2f2b37 into main Dec 7, 2021
@stephybun stephybun deleted the f/df-deprecate-name branch December 7, 2021 08:32
@github-actions github-actions bot added this to the v2.89.0 milestone Dec 7, 2021
stephybun added a commit that referenced this pull request Dec 7, 2021
@stephybun
Update for #14492
782ae5f
@github-actions
Copy link

This functionality has been released in v2.89.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
deprecation documentation service/data-factory size/XL
Projects
None yet
Milestone
v2.89.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stephybun @manicminer