Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_group: support for ip_address_type = None #14460

Merged

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Dec 3, 2021

  • Update containerinstance SDK to 2021-03-01
  • Add None as a possible value to ip_address_type to allow for
    container groups without networking
  • Fix acceptance tests to use new syntax
  • Remove limitation of network_profile_id in combination with SystemIdentity (it works nowadays)

Fixes #1697
Fixes #14451

@favoretti
Copy link
Collaborator Author

image

* Update `containerinstance` SDK to `2021-03-01`
* Add `None` as a possible value to `ip_address_type` to allow for
  container groups without networking
@favoretti favoretti force-pushed the favoretti/container_group_networking branch from 21eebcb to 5a5a0f2 Compare December 8, 2021 07:15
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v2.90.0 milestone Dec 16, 2021
@mbfrahry mbfrahry changed the title r/azurerm_container_group: Add ip_address_type = None azurerm_container_group: support for ip_address_type = None Dec 16, 2021
@mbfrahry mbfrahry merged commit e8e83bd into hashicorp:main Dec 16, 2021
mbfrahry added a commit that referenced this pull request Dec 16, 2021
@github-actions
Copy link

This functionality has been released in v2.90.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants