Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new resource "azurerm_synapse_sql_pool_workload_classifier" #14412

Merged
merged 4 commits into from
Dec 16, 2021
Merged

new resource "azurerm_synapse_sql_pool_workload_classifier" #14412

merged 4 commits into from
Dec 16, 2021

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Dec 1, 2021 •
edited
Loading

image

@ms-henglu ms-henglu force-pushed the ticket-11110912-synapse-workload-classifier branch from 2426154 to 327d550 Compare December 1, 2021 03:34
katbyte
katbyte reviewed Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - overall looks good but i have some minor comments to address that i've left inline

internal/services/synapse/synapse_sql_pool_workload_classifier_resource.go Show resolved Hide resolved
internal/services/synapse/synapse_sql_pool_workload_classifier_resource.go Show resolved Hide resolved
website/docs/r/synapse_sql_pool_workload_classifier.html.markdown Outdated Show resolved Hide resolved
website/docs/r/synapse_sql_pool_workload_classifier.html.markdown Outdated Show resolved Hide resolved
website/docs/r/synapse_sql_pool_workload_classifier.html.markdown Outdated Show resolved Hide resolved
website/docs/r/synapse_sql_pool_workload_classifier.html.markdown Outdated Show resolved Hide resolved
website/docs/r/synapse_sql_pool_workload_classifier.html.markdown Outdated Show resolved Hide resolved
@ms-henglu ms-henglu force-pushed the ticket-11110912-synapse-workload-classifier branch from 3a40f38 to b9e4b7f Compare December 10, 2021 07:06
katbyte
katbyte approved these changes Dec 16, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - LGTM 🏗️

@katbyte katbyte merged commit ef4940b into hashicorp:main Dec 16, 2021
katbyte added a commit that referenced this pull request Dec 16, 2021
@katbyte
CHANGELOG.md for #14412
3fe9778
@github-actions github-actions bot added this to the v2.90.0 milestone Dec 16, 2021
@github-actions
Copy link

This functionality has been released in v2.90.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/synapse size/XL
Projects
None yet
Milestone
v2.90.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ms-henglu @katbyte @tombuildsstuff