New Resource: azurerm_consumption_budget_management_group

[josh-barker]

This PR creates a new resources for the managing a consumption budget for management groups.

Whilst developing this I found that the schema is slightly different to resource groups and subscriptions.

• contact_roles are not supported
• contact_groups are not supported

This then changes the requirements for contact_emails making them mandatory and a minimum of 1 element.

I used go-generate to help create the initial outline for the ID resources, but as management group IDs do not have a subscription, I had to use ParseAzureResourceIDWithoutSubscription.

Addresses #13112

[stephybun]

Thanks for this PR @josh-barker. Overall this looks good, once the docs have been fixed up and the comment on the schema addressed this should be good to go!

[stephybun]

Suggested change

	A `filter` block supports the following:
	A `filter` block exports the following:

[josh-barker]

Hey @stephybun,

Thanks for all your feedback.

In the other consumption resources, the reference object is not consistent.

The azurerm_consumption_budget_subscription resource uses subscription_id which is specified as xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx.
However, the azurerm_consumption_budget_resource_group resource uses resource_group_id which is specified as /subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/example-rg.

Are you asking the implementation to be changed to this?

• managment_group_id = "/providers/Microsoft.Management/managementGroups/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
• managment_group_id = azurerm_management_group.example.id

[stephybun]

Hey @josh-barker,

Apologies I should have clarified further, the implementation should be changed to use the management group resource ID, so this form:
managment_group_id = "/providers/Microsoft.Management/managementGroups/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"

[johnroach]

Thank you @josh-barker really need this! Can't wait for this to be merged. Please do reach out if you need any help!

[josh-barker]

Hey @stephybun, I've implemented all of your requested changes except for the request to change supports to exports as the documentation is under the Arguments Reference heading.

[stephybun]

Thanks @josh-barker, LGTM 👍🏼

[github-actions]

This functionality has been released in v2.89.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.