azurerm_signalr_service - deprecate features block in favour of connectivity_logs_enabled, messaging_logs_enabled and service_mode #14360
Conversation
…enabled and service_mode
There was a problem hiding this comment.
hey @catriona-m
Thanks for this PR - taking a look through on the whole this is looking good, however can we flip these over to using Bool's instead of Strings here?
Thanks!
| Type: pluginsdk.TypeString, | ||
| Optional: true, | ||
| Computed: true, | ||
| ConflictsWith: []string{ | ||
| "features", | ||
| }, | ||
| ValidateFunc: validation.StringInSlice([]string{ | ||
| "Serverless", | ||
| "Classic", | ||
| "Default", | ||
| }, false), |
There was a problem hiding this comment.
is there a default value for this ("Default"?) - also this shouldn't be computed
There was a problem hiding this comment.
I've had to make these computed so the deprecation will function correctly, but I've left a note to remove for 3.0
|
This functionality has been released in v2.89.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.