Support in-place update of app service slots

[phekmat]

• Upgrade to 2018-02-01 of the App Service API
• Remove ForceNew on several slot attributes and update them in place

Fixes #1335

[tombuildsstuff]

hey @phekmat

Thanks for this PR - this LGTM 👍

[katbyte]

One of the tests is failing:

------- Stdout: -------
=== RUN   TestAccAzureRMAppServiceSlot_clientAffinityEnabledUpdate
--- FAIL: TestAccAzureRMAppServiceSlot_clientAffinityEnabledUpdate (157.39s)
    testing.go:513: Step 1 error: Check failed: Check 2/2 error: azurerm_app_service_slot.test: Attribute 'client_affinity_enabled' expected "false", got "true"
FAIL

[phekmat]

@katbyte I pushed a fix for that (roughly the same as the one added in 61a1069)

[katbyte]

@phekmat,

there are two of the older tests still failing with the same error:

------- Stdout: -------
=== RUN   TestAccAzureRMAppServiceSlot_manyIpRestrictions
--- FAIL: TestAccAzureRMAppServiceSlot_manyIpRestrictions (108.74s)
    testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        
        * azurerm_app_service_slot.test: 1 error(s) occurred:
        
        * azurerm_app_service_slot.test: web.AppsClient#CreateOrUpdateSlot: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="BadRequest" Message="IpSecurityRestriction.IpAddress is invalid." Details=[{"Message":"IpSecurityRestriction.IpAddress is invalid."},{"Code":"BadRequest"},{"ErrorEntity":{"Code":"BadRequest","ExtendedCode":"51012","Message":"IpSecurityRestriction.IpAddress is invalid.","MessageTemplate":"{0} is invalid.","Parameters":["IpSecurityRestriction.IpAddress"]}}]
FAIL

------- Stdout: -------
=== RUN   TestAccAzureRMAppServiceSlot_oneIpRestriction
--- FAIL: TestAccAzureRMAppServiceSlot_oneIpRestriction (104.85s)
    testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        
        * azurerm_app_service_slot.test: 1 error(s) occurred:
        
        * azurerm_app_service_slot.test: web.AppsClient#CreateOrUpdateSlot: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="BadRequest" Message="IpSecurityRestriction.IpAddress is invalid." Details=[{"Message":"IpSecurityRestriction.IpAddress is invalid."},{"Code":"BadRequest"},{"ErrorEntity":{"Code":"BadRequest","ExtendedCode":"51012","Message":"IpSecurityRestriction.IpAddress is invalid.","MessageTemplate":"{0} is invalid.","Parameters":["IpSecurityRestriction.IpAddress"]}}]
FAIL

These seem to be new and unique to your PR. Apologies for missing these earlier. I just tested the ones you had added at first.

[phekmat]

Thanks for that @katbyte. It looks like the same tests are failing for the regular app_service resource, so it's likely due to the new API version.

I'll try to find some time to debug the issue.

[phekmat]

Minor update, it looks like the new version of the API has both removed the subnetMask field (or rather, throws back a 400 if it's included) and requires that the IP address be in CIDR notation (x.x.x.x/y). I couldn't find any documentation of this new behavior, but it should be straightforward to work around it.

[tombuildsstuff]

@phekmat is updating App Service Slots dependent on the API upgrade? If not it may be worth removing that change for the moment?

waiting on feedback

[phekmat]

The API upgrade is required IIRC. The Swagger was updated for the old API for web apps in Azure/azure-rest-api-specs#2664, but those fields are still there for slots. I believe I ran into the same issue as you did in Azure/azure-rest-api-specs#1697

[phekmat]

I've rebased and added the IP/mask translation, so this should be good for review again. Apologies for the delay

[tombuildsstuff]

hey @phekmat

Thanks for pushing the latest changes here - I've taken a look through and this now LGTM, I'll kick off the tests suite now 👍🏻

Thanks!

[tombuildsstuff]

All the App Service related tests pass:

[tombuildsstuff]

hi @phekmat

Just to let you know that is now available in v1.10 of the AzureRM Provider - which you can update to this version by specifying it in the Provider block, like so:

provider "azurerm" {
  version = "=1.10.0"
}

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!