r\purview_account: Add support for managed_resource_group_name
#14217
Conversation
There was a problem hiding this comment.
Thanks @myc2h6o! Looks good so far, just left a couple of minor comments inline.
| @@ -39,6 +39,10 @@ The following arguments are supported: | |||
|
|
|||
| * `public_network_enabled` - (Optional) Should the Purview Account be visible to the public network? Defaults to `true`. | |||
|
|
|||
| * `managed_resource_group_name` - (Optional) The name of the Resource Group where Purview Account creates the managed resources. | |||
There was a problem hiding this comment.
We could remove the note and change the description:
| * `managed_resource_group_name` - (Optional) The name of the Resource Group where Purview Account creates the managed resources. | |
| * `managed_resource_group_name` - (Optional) The name which should be used for the new Resource Group where Purview Account creates the managed resources. Changing this forces a new Purview Account to be created. |
There was a problem hiding this comment.
Description updated
| Config: r.withManagedResourceGroupName(data), | ||
| Check: acceptance.ComposeTestCheckFunc( | ||
| check.That(data.ResourceName).ExistsInAzure(r), | ||
| ), |
There was a problem hiding this comment.
could this include a check to see if the managed_resource_group_name itself has been set?
There was a problem hiding this comment.
Moved managed_resource_group_name to parameter and added the check for it.
I removed the update part as well since this is a ForceNew property
|
@catriona-m thanks for reviewing the change. I've resolved your comments, please take another look. |
myc2h6o
force-pushed
the
purview_managed_rg
branch
2 times, most recently
from
c7b9d5c
to
d2e11df
Compare
|
This functionality has been released in v2.86.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
$ TF_ACC=1 go test -v ./internal/services/purview -run=TestAccPurviewAccount_ -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccPurviewAccount_basic
=== PAUSE TestAccPurviewAccount_basic
=== RUN TestAccPurviewAccount_requiresImport
=== PAUSE TestAccPurviewAccount_requiresImport
=== RUN TestAccPurviewAccount_withManagedResourceGroupName
=== PAUSE TestAccPurviewAccount_withManagedResourceGroupName
=== CONT TestAccPurviewAccount_basic
=== CONT TestAccPurviewAccount_withManagedResourceGroupName
=== CONT TestAccPurviewAccount_requiresImport
--- PASS: TestAccPurviewAccount_withManagedResourceGroupName (642.22s)
--- PASS: TestAccPurviewAccount_requiresImport (663.07s)
--- PASS: TestAccPurviewAccount_basic (735.61s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/purview 736.292s