Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function slot WEBSITE_CONTENTSHARE secretly changes #14211

Merged
merged 3 commits into from
Nov 25, 2021

Conversation

uolter
Copy link
Contributor

@uolter uolter commented Nov 16, 2021

This PR is aiming to fix the issue reported here:
fixes #14206

@uolter
Copy link
Contributor Author

uolter commented Nov 18, 2021

@jackofallops the real changes to apply are in the file:
internal/services/web/function_app_slot_resource.go
I've tried to use the same logic already in place for the function itself in:

  • internal/services/web/function_app.go
  • internal/services/web/function_app_resource.go
    I hope you are going to fix this issue soon :-)

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @uolter - Apologies for the delay. Thanks for this PR.

It looks mostly good, just a couple comments that need removing. Also, could you remove the unrelated files from the PR? Once that's addressed, I can authorise the workflows and get this through testing.

Thanks again!

internal/services/web/function_app_slot_resource.go Outdated Show resolved Hide resolved
internal/services/web/function_app_slot_resource.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/S and removed size/L labels Nov 25, 2021
@uolter
Copy link
Contributor Author

uolter commented Nov 25, 2021

@jackofallops thanks for coming back to me. I've applied all changes you suggested.
Please, let me know if something else is not appropriate.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick updates @uolter, this LGTM now 👍

@jackofallops
Copy link
Member

Tests passing:
image

@jackofallops jackofallops added this to the v2.87.0 milestone Nov 25, 2021
@jackofallops jackofallops merged commit fe8b902 into hashicorp:main Nov 25, 2021
jackofallops added a commit that referenced this pull request Nov 25, 2021
@github-actions
Copy link

This functionality has been released in v2.87.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function app slot (azurerm_function_app_slot) WEBSITE_CONTENTSHARE secretly changes
2 participants