Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Service Beta - support for Load Balancer timeouts and VNet Route All. #14202

Merged
merged 6 commits into from
Nov 16, 2021

Conversation

jackofallops
Copy link
Member

azurerm_windows_web_app - add support for health_check_eviction_time and vnet_route_all_enabled.
azurerm_linux_web_app - add support for health_check_eviction_time and vnet_route_all_enabled.
fixes a bug in the default value for use_32_bit_worker

Also addresses some delta-update changes and refactoring for utils.NormaliseNilableBool

@jackofallops jackofallops added this to the v2.86.0 milestone Nov 16, 2021
@jackofallops jackofallops self-assigned this Nov 16, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one comment LGTM 🏗️

internal/services/appservice/helpers/web_app_schema.go Outdated Show resolved Hide resolved
@jackofallops jackofallops merged commit de80743 into main Nov 16, 2021
@jackofallops jackofallops deleted the f/app-service-beta-update branch November 16, 2021 17:08
jackofallops added a commit that referenced this pull request Nov 16, 2021
@github-actions
Copy link

This functionality has been released in v2.86.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants