azurerm_mssql_database: Fix error with OnlineSecondary with auditing on Primary

[aristosvo]

Fixes #14176

No AccTests specified, not sure if that would be necessary, happy to add if necessary

[mbfrahry]

This looks great but a test would be perfect 🙈

[aristosvo]

@mbfrahry Here they are! 🚀

TF_ACC=1 go test -v ./internal/services/mssql -run=TestAccMsSqlDatabaseExtendedAuditingPolicy_primaryWithOnlineSecondary\|TestAccMsSqlDatabase_createSecondaryMode -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMsSqlDatabaseExtendedAuditingPolicy_primaryWithOnlineSecondary
=== PAUSE TestAccMsSqlDatabaseExtendedAuditingPolicy_primaryWithOnlineSecondary
=== RUN   TestAccMsSqlDatabase_createSecondaryMode
=== PAUSE TestAccMsSqlDatabase_createSecondaryMode
=== CONT  TestAccMsSqlDatabaseExtendedAuditingPolicy_primaryWithOnlineSecondary
--- PASS: TestAccMsSqlDatabaseExtendedAuditingPolicy_primaryWithOnlineSecondary (719.02s)
=== CONT  TestAccMsSqlDatabase_createSecondaryMode
--- PASS: TestAccMsSqlDatabase_createSecondaryMode (922.04s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mssql 923.660s

[mbfrahry]

Thanks for that but I'm seeing an issue with this test now TestAccMsSqlDatabase_createOnlineSecondaryMode

------- Stdout: -------
=== RUN   TestAccMsSqlDatabase_createOnlineSecondaryMode
=== PAUSE TestAccMsSqlDatabase_createOnlineSecondaryMode
=== CONT  TestAccMsSqlDatabase_createOnlineSecondaryMode
testcase.go:110: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
(map[string]string) (len=1) {
(string) (len=11) "create_mode": (string) (len=9) "Secondary"
}
(map[string]string) (len=1) {
(string) (len=11) "create_mode": (string) (len=15) "OnlineSecondary"
}
--- FAIL: TestAccMsSqlDatabase_createOnlineSecondaryMode (648.86s)
FAIL

[aristosvo]

Sorry! I didn't commit all of it apparently😢

TF_ACC=1 go test -v ./internal/services/mssql -run=TestAccMsSqlDatabase_createSecondaryMode -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMsSqlDatabase_createSecondaryMode
=== PAUSE TestAccMsSqlDatabase_createSecondaryMode
=== CONT  TestAccMsSqlDatabase_createSecondaryMode
--- PASS: TestAccMsSqlDatabase_createSecondaryMode (742.86s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mssql 744.490s

[mbfrahry]

LGTM! Thanks for this @aristosvo

[github-actions]

This functionality has been released in v2.86.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.