azurerm_mssql_server - support azuread_authentication_only on create

[aristosvo]

Missed scenario fixed while looking at another issue.

azuread_authentication_only worked only on update, now also on create.

Acceptance Tests

go install && make acctests SERVICE='mssql' TESTARGS='-run=TestAccMsSqlServer_azureadAdmin'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/mssql -run=TestAccMsSqlServer_azureadAdmin -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMsSqlServer_azureadAdmin
=== PAUSE TestAccMsSqlServer_azureadAdmin
=== RUN   TestAccMsSqlServer_azureadAdminUpdate
=== PAUSE TestAccMsSqlServer_azureadAdminUpdate
=== RUN   TestAccMsSqlServer_azureadAdminWithAADAuthOnly
=== PAUSE TestAccMsSqlServer_azureadAdminWithAADAuthOnly
=== CONT  TestAccMsSqlServer_azureadAdmin
=== CONT  TestAccMsSqlServer_azureadAdminWithAADAuthOnly
=== CONT  TestAccMsSqlServer_azureadAdminUpdate
=== CONT  TestAccMsSqlServer_azureadAdminWithAADAuthOnly
=== CONT  TestAccMsSqlServer_azureadAdminUpdate
=== CONT  TestAccMsSqlServer_azureadAdminWithAADAuthOnly
=== CONT  TestAccMsSqlServer_azureadAdmin
=== CONT  TestAccMsSqlServer_azureadAdminUpdate
--- PASS: TestAccMsSqlServer_azureadAdmin (480.10s)
=== CONT  TestAccMsSqlServer_azureadAdminUpdate
--- PASS: TestAccMsSqlServer_azureadAdminWithAADAuthOnly (620.03s)
=== CONT  TestAccMsSqlServer_azureadAdminUpdate
--- PASS: TestAccMsSqlServer_azureadAdminUpdate (1031.82s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mssql 1034.114s

[katbyte]

as with the other PR, think we need to update the docs as well?

[aristosvo]

as with the other PR, think we need to update the docs as well?

This PR fixes existing functionality. It is already documented, but contained a bug unfortunately, the docs:

• azuread_authentication_only - (Optional) Specifies whether only AD Users and administrators (like azuread_administrator.0.login_username) can be used to login or also local database users (like administrator_login)

[katbyte]

ahh thanks for the clarification @aristosvo - LGTM 🚀

[github-actions]

This functionality has been released in v2.86.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.