Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - Support for outbound_type = "*NATGateway" and nat_gateway_profile #14142

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Nov 11, 2021

Fixes #14138

Acceptance Tests

  • outboundType = "managedNATGateway"
TF_ACC=1 go test -v ./internal/services/containers -run=TestAccKubernetesCluster_managedNatGateway -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccKubernetesCluster_managedNatGateway
=== PAUSE TestAccKubernetesCluster_managedNatGateway
=== CONT  TestAccKubernetesCluster_managedNatGateway
--- PASS: TestAccKubernetesCluster_managedNatGateway (589.09s)
PASS
ok   github.com/hashicorp/terraform-provider-azurerm/internal/services/containers     590.831s
  • outboundType = "managedNATGateway" with nat_gateway_profile settings
TF_ACC=1 go test -v ./internal/services/containers -run=TestAccKubernetesCluster_natGatewayProfile -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccKubernetesCluster_natGatewayProfile
=== PAUSE TestAccKubernetesCluster_natGatewayProfile
=== CONT  TestAccKubernetesCluster_natGatewayProfile
--- PASS: TestAccKubernetesCluster_natGatewayProfile (748.23s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/service
  • outboundType = "userAssignedNATGateway"
TF_ACC=1 go test -v ./internal/services/containers -run=TestAccKubernetesCluster_userAssignedNatGateway -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccKubernetesCluster_userAssignedNatGateway
=== PAUSE TestAccKubernetesCluster_userAssignedNatGateway
=== CONT  TestAccKubernetesCluster_userAssignedNatGateway
--- PASS: TestAccKubernetesCluster_userAssignedNatGateway (647.71s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers     649.450s

@aristosvo aristosvo force-pushed the containers/kubernetes-nat-gateway branch 3 times, most recently from 721fdc7 to e8f8e3a Compare November 11, 2021 11:23
@github-actions github-actions bot added size/XL and removed size/L labels Nov 11, 2021
@aristosvo aristosvo changed the title azurerm_kubernetes_cluster - Support for outbound_type = *NATGateway and nat_gateway_profile azurerm_kubernetes_cluster - Support for outbound_type = "*NATGateway" and nat_gateway_profile Nov 11, 2021
@aristosvo aristosvo force-pushed the containers/kubernetes-nat-gateway branch from e8f8e3a to bd72da1 Compare November 11, 2021 11:33
@aristosvo aristosvo marked this pull request as draft November 11, 2021 11:34
@aristosvo aristosvo force-pushed the containers/kubernetes-nat-gateway branch 2 times, most recently from c4f4cef to 36ab9f8 Compare November 11, 2021 12:08
@aristosvo aristosvo force-pushed the containers/kubernetes-nat-gateway branch from 36ab9f8 to 42751b8 Compare November 11, 2021 12:42
@aristosvo aristosvo marked this pull request as ready for review November 11, 2021 13:00
@MrImpossibru
Copy link

Hello. Will it be possible to review this before next release? Thanks. It will help me a lot.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @aristosvo ! 🚀

@katbyte katbyte merged commit 02bf795 into hashicorp:main Nov 19, 2021
@github-actions github-actions bot added this to the v2.86.0 milestone Nov 19, 2021
katbyte added a commit that referenced this pull request Nov 19, 2021
@github-actions
Copy link

This functionality has been released in v2.86.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for new AKS outbound settings: managedNATGateway and userAssignedNATGateway
3 participants