New Resource: azurerm_sql_managed_instance_active_directory_administrator

[aristosvo]

Fixes #13957

Needs azuread v2 via #14105
Needs merge of #14052

Acceptance Tests

TF_ACC=1 go test -v ./internal/services/sql -run=TestAccSqlMiAdministrator_basic -timeout 1800m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccSqlMiAdministrator_basic
=== PAUSE TestAccSqlMiAdministrator_basic
=== CONT  TestAccSqlMiAdministrator_basic
--- PASS: TestAccSqlMiAdministrator_basic (17391.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/sql	17391.752s

[katbyte]

Hmm, looks like we need to increase the timeouts even more?

------- Stdout: -------
=== RUN   TestAccAzureRMSqlMiServer_basic
=== PAUSE TestAccAzureRMSqlMiServer_basic
=== CONT  TestAccAzureRMSqlMiServer_basic
    testcase.go:110: Step 1/2 error: Error running apply: exit status 1
        
        Error: sql.ManagedInstancesClient#CreateOrUpdate: Failure sending request: StatusCode=504 -- Original Error: Code="GatewayTimeout" Message="The gateway did not receive a response from 'Microsoft.Sql' within the specified time period."
        
          with azurerm_sql_managed_instance.test,
          on terraform_plugin_test.tf line 1142, in resource "azurerm_sql_managed_instance" "test":
        1142: resource "azurerm_sql_managed_instance" "test" {
        
--- FAIL: TestAccAzureRMSqlMiServer_basic (1289.87s)
FAIL

[aristosvo]

@katbyte which timeouts can we possibly change here? This seems like a timeout of the Azure API, not a resource creation timeout AFAIK.

The resource create timeout for a Managed Instance is 24hrs, which is much more than current the 20 minutes timeout we're facing..? This looks like an Azure API instability issue

[aristosvo]

Currently waiting for response on Azure/azure-rest-api-specs#16838

Edit: found a workaround, first tests are promising:

// azurerm_sql_managed_instance is working again
❯ TF_ACC=1 go test -v ./internal/services/sql -run=TestAccAzureRMSqlMiServer_basic -timeout 1800m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMSqlMiServer_basic
=== PAUSE TestAccAzureRMSqlMiServer_basic
=== CONT  TestAccAzureRMSqlMiServer_basic
    testcase.go:110: Step 1/2 is completed for TestAccAzureRMSqlMiServer_basic
    testcase.go:110: Step 2/2 is completed for TestAccAzureRMSqlMiServer_basic
--- PASS: TestAccAzureRMSqlMiServer_basic (16103.77s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/sql   16106.193s

// Identity works as expected
❯ TF_ACC=1 go test -v ./internal/services/sql -run=TestAccAzureRMSqlMiServer_identity -timeout 1800m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMSqlMiServer_identity
=== PAUSE TestAccAzureRMSqlMiServer_identity
=== CONT  TestAccAzureRMSqlMiServer_identity
--- PASS: TestAccAzureRMSqlMiServer_identity (18194.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/sql	18194.833s

[aristosvo]

Another error on import:

--- PASS: TestAccSqlMiAdministrator_basic (17654.32s)
=== CONT  TestAccSqlMiAdministrator_requiresImport
    testcase.go:110: Step 3/3, expected an error with pattern, no match on: Error running pre-apply refresh: exit status 1
        
        Error: Reference to undeclared resource

[aristosvo]

And last test fixed:

--- PASS: TestAccSqlMiAdministrator_requiresImport (15679.28s)

[mbfrahry]

Hey @aristosvo! This PR looks good with just a couple callouts

[aristosvo]

Rebased and squashed!

[mbfrahry]

LGTM! Thanks @aristosvo

[github-actions]

This functionality has been released in v2.89.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.