Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource azurerm_logz_tag_rule #14020

Merged
merged 10 commits into from
Nov 18, 2021
Merged

Conversation

@ms-zhenhua
Copy link
Contributor Author

Hi @katbyte, Thank you for reviewing my code, I've added a commit according to your comments, please kindly help take another look, thanks!

@katbyte
Copy link
Collaborator

katbyte commented Nov 11, 2021

We have some test failures:

------- Stdout: -------
=== RUN   TestAccLogzTagRule_complete
=== PAUSE TestAccLogzTagRule_complete
=== CONT  TestAccLogzTagRule_complete
    testcase.go:109: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating Logz Monitor: (Monitor Name "liftr_test_only_1111174006921708" / Resource Group "acctest-logz-211111174006921708"): logz.MonitorsClient#Create: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="InvalidResourceOperation" Message="The operation for resource '/subscriptions/*******/resourceGroups/acctest-logz-211111174006921708/providers/Microsoft.Logz/monitors/liftr_test_only_1111174006921708' is invalid as it is being provisioned with state: 'Accepted'."
        
          with azurerm_logz_monitor.test,
          on terraform_plugin_test.tf line 12, in resource "azurerm_logz_monitor" "test":
          12: resource "azurerm_logz_monitor" "test" {
        
--- FAIL: TestAccLogzTagRule_complete (241.87s)
FAIL

@katbyte katbyte modified the milestones: v2.85.0, v2.86.0 Nov 12, 2021
@ms-zhenhua
Copy link
Contributor Author

Hi @katbyte , Thank you for your reminder. I am looking into this issue now.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-zhenhua - LGTM 💯

@katbyte katbyte changed the title new resource Logz tag rule new resource azurerm_logz_tag_rule Nov 18, 2021
@katbyte katbyte merged commit 316f916 into hashicorp:main Nov 18, 2021
katbyte added a commit that referenced this pull request Nov 18, 2021
@github-actions
Copy link

This functionality has been released in v2.86.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants