-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_sql_managed_instance
: Support for dns_zone_partner_id
#13951
azurerm_sql_managed_instance
: Support for dns_zone_partner_id
#13951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're missing docs?
9c69194
to
97f3b36
Compare
97f3b36
to
569cbf1
Compare
Acceptance Tests are passing: TF_ACC=1 go test -v ./internal/services/sql -run=TestAccAzureRMSqlMiServer_dnsZonePartner -timeout 1800m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMSqlMiServer_dnsZonePartner
=== PAUSE TestAccAzureRMSqlMiServer_dnsZonePartner
=== CONT TestAccAzureRMSqlMiServer_dnsZonePartner
--- PASS: TestAccAzureRMSqlMiServer_dnsZonePartner (31669.68s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/sql 31671.235s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aristosvo - LGTM 👍
This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #13932 (½)
This PR is the first step of 2 towards the failover capability as described in #13932. This first step makes it possible to share the DNS zone, to make failover possible. Documentation about failover for MI can be found here.
Acceptance Tests
ToDo