Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_sql_managed_instance: Support for dns_zone_partner_id #13951

Merged

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Oct 28, 2021

Fixes #13932 (½)

This PR is the first step of 2 towards the failover capability as described in #13932. This first step makes it possible to share the DNS zone, to make failover possible. Documentation about failover for MI can be found here.

Acceptance Tests

TF_ACC=1 go test -v ./internal/services/sql -run=TestAccAzureRMSqlMiServer_dnsZonePartner -timeout 1800m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMSqlMiServer_dnsZonePartner
=== PAUSE TestAccAzureRMSqlMiServer_dnsZonePartner
=== CONT  TestAccAzureRMSqlMiServer_dnsZonePartner
--- PASS: TestAccAzureRMSqlMiServer_dnsZonePartner (31669.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/sql	31671.235s

ToDo

  • Docs
  • Run the Acceptance Test (takes a long time.., this issue verifies if we could possibly speed it up a bit)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're missing docs?

@aristosvo aristosvo force-pushed the sql/managed-instance-dns-partner-zone branch from 97f3b36 to 569cbf1 Compare October 31, 2021 21:22
@aristosvo
Copy link
Collaborator Author

Acceptance Tests are passing:

TF_ACC=1 go test -v ./internal/services/sql -run=TestAccAzureRMSqlMiServer_dnsZonePartner -timeout 1800m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMSqlMiServer_dnsZonePartner
=== PAUSE TestAccAzureRMSqlMiServer_dnsZonePartner
=== CONT  TestAccAzureRMSqlMiServer_dnsZonePartner
--- PASS: TestAccAzureRMSqlMiServer_dnsZonePartner (31669.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/sql	31671.235s

@katbyte katbyte added this to the v2.84.0 milestone Nov 2, 2021
@katbyte katbyte added the service/mssql Microsoft SQL Server label Nov 2, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - LGTM 👍

@katbyte katbyte merged commit 0afa7d3 into hashicorp:main Nov 2, 2021
katbyte added a commit that referenced this pull request Nov 2, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for geo-replication of a SQL Managed Instance
2 participants