New resource: `azurerm_automation_webhook` #13893

wiktorn · 2021-10-25T20:38:12Z

I haven't tested and I guess that it doesn't support URI rotation as I described:

it would be helpful if provider would support one of the following rotation scenarios

changing the name of the webhook would result in first creation of the new resource, updating references to it in dependant resources and in the end removal of old webhook (not sure if such plans are supported by terraform)

changing of the expiration date would generate automatically new URI which forces resource replacement and goes as above

I don't know if this is at all possible.

Test results:

TF_ACC=1 go test -v ./internal/services/automation -run=TestAccAutomationWebhook -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAutomationWebhook_basic
=== PAUSE TestAccAutomationWebhook_basic
=== RUN   TestAccAutomationWebhook_requiresImport
=== PAUSE TestAccAutomationWebhook_requiresImport
=== RUN   TestAccAutomationWebhook_WithParameters
=== PAUSE TestAccAutomationWebhook_WithParameters
=== CONT  TestAccAutomationWebhook_basic
=== CONT  TestAccAutomationWebhook_WithParameters
=== CONT  TestAccAutomationWebhook_requiresImport
--- PASS: TestAccAutomationWebhook_WithParameters (87.52s)
--- PASS: TestAccAutomationWebhook_requiresImport (101.67s)
--- PASS: TestAccAutomationWebhook_basic (149.38s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/automation    149.396s

~~I'm still working on the documentation~~

Add test to check if url's are updated properly.

katbyte

Thanks for the new resource @wiktorn - overall looks good but i had some questions/comments i've left inline

katbyte · 2021-11-03T21:29:04Z

internal/services/automation/automation_webhook.go

+	}
+}
+
+func resourceAutomationWebhookCommonSchema() map[string]*pluginsdk.Schema {


i'm not sure what we gain from this being a seperate function? could we just inline it?

Yes, we can inline that. I will update PR tomorrow.

katbyte · 2021-11-03T21:29:26Z

internal/services/automation/automation_webhook.go

+			Required:     true,
+			ValidateFunc: validate.RunbookName(),
+		},
+		"run_on": {


could we make this

Suggested change

"run_on": {

"run_on_worker_group": {

to be a little more explicit what it means

katbyte · 2021-11-03T21:29:41Z

internal/services/automation/automation_webhook.go

+			ForceNew:   true,
+			Computed:   true,
+			Sensitive:  true,
+		},


should we validate this?

Yes, good catch. What's easy to add is: IsURLWithHTTPorHTTPS. I don't think that there is any official pattern/domain, that we can validate. IIRC API was accepting some invalid (not pointing to Azure) urls on creation (but not on update...)

katbyte · 2021-11-03T21:31:20Z

internal/services/automation/automation_webhook_test.go

+}
+
+/*
+// missing workergroup creation


is there no way to create a worker group yet?

It's not exposed in Azure REST API. I guess that this might be due to the fact, that worker group is created when agent is installed and registered in Azure. I assumed, that this is only resource missing in terraform, but as I've just now checked, I think it is better just to remove this case

can you pass in a fake value?

I can pass the fake value, the only thing is, that there will be an error returned from REST API. As it is quite specific, I've implemented it right now, as expecting this specific error.

* use `run_on_worker_group` instead of `run_on` * inline schema creation function * enable test for checking `run_on_worker_group` using fake value and expect failure

wiktorn · 2021-11-16T07:27:54Z

Is there something left to do on my side to get this PR merged?

katbyte

Thanks @wiktorn! sorry for the delay in looping back here but tests pass and code looks great 🙂 Merging 🙌

github-actions · 2021-11-19T06:20:01Z

This functionality has been released in v2.86.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2021-12-20T02:10:36Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Automation webhook support

1bc5faa

github-actions bot added the size/XL label Oct 25, 2021

Documentation for azurerm_automation_webhook

ff0e02d

wiktorn marked this pull request as ready for review October 25, 2021 21:05

github-actions bot added the documentation label Oct 25, 2021

wiktorn added 4 commits October 26, 2021 08:22

Fix linting errors

f41b018

trigger GitHub actions

88cf10e

Fix uri not beeing passed to Azure.

ec461e8

Add test to check if url's are updated properly.

Force new resource on uri change

925753e

katbyte added this to the v2.83.0 milestone Oct 27, 2021

katbyte added new-resource service/automation labels Oct 27, 2021

katbyte modified the milestones: v2.83.0, v2.84.0 Oct 29, 2021

katbyte requested changes Nov 3, 2021

View reviewed changes

PR review changes

be9f107

* use `run_on_worker_group` instead of `run_on` * inline schema creation function * enable test for checking `run_on_worker_group` using fake value and expect failure

wiktorn requested a review from katbyte November 4, 2021 08:52

katbyte modified the milestones: v2.84.0, v2.85.0, v2.86.0 Nov 5, 2021

katbyte approved these changes Nov 18, 2021

View reviewed changes

katbyte merged commit 287f81c into hashicorp:main Nov 18, 2021

katbyte added a commit that referenced this pull request Nov 18, 2021

CHANGELOG.md for #13893

1fea8e8

github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: `azurerm_automation_webhook` #13893

New resource: `azurerm_automation_webhook` #13893

wiktorn commented Oct 25, 2021 •

edited

Loading

katbyte left a comment

katbyte Nov 3, 2021

wiktorn Nov 3, 2021

wiktorn Nov 4, 2021

katbyte Nov 3, 2021

wiktorn Nov 4, 2021

katbyte Nov 3, 2021

wiktorn Nov 3, 2021

wiktorn Nov 4, 2021

katbyte Nov 3, 2021

wiktorn Nov 3, 2021

katbyte Nov 3, 2021

wiktorn Nov 4, 2021

wiktorn commented Nov 16, 2021

katbyte left a comment

github-actions bot commented Nov 19, 2021

github-actions bot commented Dec 20, 2021

New resource: azurerm_automation_webhook #13893

New resource: azurerm_automation_webhook #13893

Conversation

wiktorn commented Oct 25, 2021 • edited Loading

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wiktorn commented Nov 16, 2021

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 19, 2021

github-actions bot commented Dec 20, 2021

New resource: `azurerm_automation_webhook` #13893

New resource: `azurerm_automation_webhook` #13893

wiktorn commented Oct 25, 2021 •

edited

Loading