Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/azurerm_eventgrid_system_topic: New data source #13851

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

aristosvo
Copy link
Collaborator

Fixes #13846

Acceptance Tests:

❯ go install && make acctests SERVICE='eventgrid' TESTARGS='-run=TestAccEventGridSystemTopicDataSource_'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/eventgrid -run=TestAccEventGridSystemTopicDataSource_ -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccEventGridSystemTopicDataSource_complete
=== PAUSE TestAccEventGridSystemTopicDataSource_complete
=== RUN   TestAccEventGridSystemTopicDataSource_basicWithSystemManagedIdentity
=== PAUSE TestAccEventGridSystemTopicDataSource_basicWithSystemManagedIdentity
=== RUN   TestAccEventGridSystemTopicDataSource_basicWithUserAssignedManagedIdentity
=== PAUSE TestAccEventGridSystemTopicDataSource_basicWithUserAssignedManagedIdentity
=== CONT  TestAccEventGridSystemTopicDataSource_complete
=== CONT  TestAccEventGridSystemTopicDataSource_basicWithUserAssignedManagedIdentity
=== CONT  TestAccEventGridSystemTopicDataSource_basicWithSystemManagedIdentity
--- PASS: TestAccEventGridSystemTopicDataSource_complete (118.19s)
--- PASS: TestAccEventGridSystemTopicDataSource_basicWithUserAssignedManagedIdentity (126.96s)
--- PASS: TestAccEventGridSystemTopicDataSource_basicWithSystemManagedIdentity (129.14s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/eventgrid     130.667s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - LGTM 💯

@katbyte katbyte added this to the v2.83.0 milestone Oct 25, 2021
@katbyte katbyte merged commit 37a9a7a into hashicorp:main Oct 25, 2021
katbyte added a commit that referenced this pull request Oct 25, 2021
@aristosvo aristosvo deleted the eventgrid/datasource-system-topic branch October 25, 2021 19:35
@github-actions
Copy link

This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
@aristosvo aristosvo restored the eventgrid/datasource-system-topic branch April 14, 2023 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for data source azurerm_eventgrid_system_topic
2 participants