Azure NetApp Files SDK updated to latest and removal of opt-in text for CRR

[paulomarquesc]

This pull request is the foundation for some upcoming new features and updates the ANF GO SDK to the latest version (2021-06-01) and removes also the requirement for customers to opt-in on Cross Region Replication from the documentation since this is now GA and no opt-in is required anymore. Finally, the enum for Service level had to be updated due to the newer version of the SDK.

Since the SDK got updated, executed all acceptance tests locally and here is the output:

❯ make acctests SERVICE='netapp' TESTARGS=' -parallel 1 -run=NetApp' TESTTIMEOUT='300m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=NetApp -timeout 300m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppAccount
=== RUN   TestAccNetAppAccount/Resource
=== RUN   TestAccNetAppAccount/Resource/update
=== PAUSE TestAccNetAppAccount/Resource/update
=== CONT  TestAccNetAppAccount/Resource/update
=== RUN   TestAccNetAppAccount/Resource#01
=== RUN   TestAccNetAppAccount/Resource#01/basic
=== PAUSE TestAccNetAppAccount/Resource#01/basic
=== CONT  TestAccNetAppAccount/Resource#01/basic
=== RUN   TestAccNetAppAccount/Resource#02
=== RUN   TestAccNetAppAccount/Resource#02/requiresImport
=== PAUSE TestAccNetAppAccount/Resource#02/requiresImport
=== CONT  TestAccNetAppAccount/Resource#02/requiresImport
=== RUN   TestAccNetAppAccount/Resource#03
=== RUN   TestAccNetAppAccount/Resource#03/complete
=== PAUSE TestAccNetAppAccount/Resource#03/complete
=== CONT  TestAccNetAppAccount/Resource#03/complete
=== RUN   TestAccNetAppAccount/DataSource
=== RUN   TestAccNetAppAccount/DataSource/basic
=== PAUSE TestAccNetAppAccount/DataSource/basic
=== CONT  TestAccNetAppAccount/DataSource/basic
--- PASS: TestAccNetAppAccount (907.45s)
    --- PASS: TestAccNetAppAccount/Resource (0.00s)
        --- PASS: TestAccNetAppAccount/Resource/update (231.74s)
    --- PASS: TestAccNetAppAccount/Resource#01 (0.00s)
        --- PASS: TestAccNetAppAccount/Resource#01/basic (165.42s)
    --- PASS: TestAccNetAppAccount/Resource#02 (0.00s)
        --- PASS: TestAccNetAppAccount/Resource#02/requiresImport (183.63s)
    --- PASS: TestAccNetAppAccount/Resource#03 (0.00s)
        --- PASS: TestAccNetAppAccount/Resource#03/complete (167.87s)
    --- PASS: TestAccNetAppAccount/DataSource (0.00s)
        --- PASS: TestAccNetAppAccount/DataSource/basic (158.80s)
=== RUN   TestAccDataSourceNetAppPool_basic
=== PAUSE TestAccDataSourceNetAppPool_basic
=== RUN   TestAccNetAppPool_basic
=== PAUSE TestAccNetAppPool_basic
=== RUN   TestAccNetAppPool_requiresImport
=== PAUSE TestAccNetAppPool_requiresImport
=== RUN   TestAccNetAppPool_complete
=== PAUSE TestAccNetAppPool_complete
=== RUN   TestAccNetAppPool_update
=== PAUSE TestAccNetAppPool_update
=== RUN   TestAccDataSourceNetAppSnapshot_basic
=== PAUSE TestAccDataSourceNetAppSnapshot_basic
=== RUN   TestAccNetAppSnapshot_basic
=== PAUSE TestAccNetAppSnapshot_basic
=== RUN   TestAccNetAppSnapshot_requiresImport
=== PAUSE TestAccNetAppSnapshot_requiresImport
=== RUN   TestAccNetAppSnapshot_complete
=== PAUSE TestAccNetAppSnapshot_complete
=== RUN   TestAccDataSourceNetAppVolume_basic
=== PAUSE TestAccDataSourceNetAppVolume_basic
=== RUN   TestAccNetAppVolume_basic
=== PAUSE TestAccNetAppVolume_basic
=== RUN   TestAccNetAppVolume_nfsv41
=== PAUSE TestAccNetAppVolume_nfsv41
=== RUN   TestAccNetAppVolume_crossRegionReplication
=== PAUSE TestAccNetAppVolume_crossRegionReplication
=== RUN   TestAccNetAppVolume_nfsv3FromSnapshot
=== PAUSE TestAccNetAppVolume_nfsv3FromSnapshot
=== RUN   TestAccNetAppVolume_nfsv3SnapshotDirectoryVisibleFalse
=== PAUSE TestAccNetAppVolume_nfsv3SnapshotDirectoryVisibleFalse
=== RUN   TestAccNetAppVolume_requiresImport
=== PAUSE TestAccNetAppVolume_requiresImport
=== RUN   TestAccNetAppVolume_complete
=== PAUSE TestAccNetAppVolume_complete
=== RUN   TestAccNetAppVolume_update
=== PAUSE TestAccNetAppVolume_update
=== RUN   TestAccNetAppVolume_updateSubnet
=== PAUSE TestAccNetAppVolume_updateSubnet
=== RUN   TestAccNetAppVolume_updateExportPolicyRule
=== PAUSE TestAccNetAppVolume_updateExportPolicyRule
=== CONT  TestAccDataSourceNetAppPool_basic
--- PASS: TestAccDataSourceNetAppPool_basic (229.63s)
=== CONT  TestAccNetAppVolume_basic
--- PASS: TestAccNetAppVolume_basic (659.62s)
=== CONT  TestAccNetAppVolume_updateExportPolicyRule
--- PASS: TestAccNetAppVolume_updateExportPolicyRule (820.08s)
=== CONT  TestAccNetAppVolume_updateSubnet
--- PASS: TestAccNetAppVolume_updateSubnet (1239.73s)
=== CONT  TestAccNetAppVolume_update
--- PASS: TestAccNetAppVolume_update (911.86s)
=== CONT  TestAccNetAppVolume_complete
--- PASS: TestAccNetAppVolume_complete (631.22s)
=== CONT  TestAccNetAppVolume_requiresImport
=== CONT  TestAccNetAppVolume_nfsv3SnapshotDirectoryVisibleFalse
--- PASS: TestAccNetAppVolume_requiresImport (677.41s)
--- PASS: TestAccNetAppVolume_nfsv3SnapshotDirectoryVisibleFalse (637.64s)
=== CONT  TestAccNetAppVolume_nfsv3FromSnapshot
--- PASS: TestAccNetAppVolume_nfsv3FromSnapshot (888.95s)
=== CONT  TestAccNetAppVolume_crossRegionReplication
--- PASS: TestAccNetAppVolume_crossRegionReplication (1282.73s)
=== CONT  TestAccNetAppVolume_nfsv41
--- PASS: TestAccNetAppVolume_nfsv41 (668.90s)
=== CONT  TestAccDataSourceNetAppSnapshot_basic
--- PASS: TestAccDataSourceNetAppSnapshot_basic (729.12s)
=== CONT  TestAccDataSourceNetAppVolume_basic
--- PASS: TestAccDataSourceNetAppVolume_basic (655.41s)
=== CONT  TestAccNetAppSnapshot_complete
--- PASS: TestAccNetAppSnapshot_complete (735.97s)
=== CONT  TestAccNetAppSnapshot_requiresImport
--- PASS: TestAccNetAppSnapshot_requiresImport (757.98s)
=== CONT  TestAccNetAppSnapshot_basic
--- PASS: TestAccNetAppSnapshot_basic (753.58s)
=== CONT  TestAccNetAppPool_complete
--- PASS: TestAccNetAppPool_complete (233.69s)
=== CONT  TestAccNetAppPool_update
--- PASS: TestAccNetAppPool_update (301.24s)
=== CONT  TestAccNetAppPool_requiresImport
--- PASS: TestAccNetAppPool_requiresImport (234.55s)
=== CONT  TestAccNetAppPool_basic
--- PASS: TestAccNetAppPool_basic (231.83s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp        14188.695s

[tombuildsstuff]

hey @paulomarquesc

Thanks for this PR - I've taken a look through and left one comment inline but this otherwise LGTM 👍

Thanks!

[paulomarquesc]

Thanks Tom, just pushed the updated documentation.

[github-actions]

This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.