Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle default value for Percentage appconfig feature filters #13771

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

koikonom
Copy link
Contributor

The code will create a percentage filter with value of 0, unless a value
is defined. This is not an acceptable configuration.

The code will create a percentage filter with value of 0, unless a value
is defined. This is not an acceptable configuration.
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @koikonom - LGTM 🩹

@koikonom koikonom merged commit e4e093c into main Oct 18, 2021
@koikonom koikonom deleted the b/no_filter_features branch October 18, 2021 15:43
koikonom pushed a commit that referenced this pull request Oct 18, 2021
@github-actions
Copy link

This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_app_configuration_feature resource creates invalid feature flags when no filters are defined
2 participants