azurerm_service_bus_queue|topic: Support for max_message_size_in_kilobytes for Premium SKU

[aristosvo]

Builds on #13760
Fixes #13514

Acceptance Tests

=== RUN   TestAccServiceBusQueue_maxMessageSizePremium
=== PAUSE TestAccServiceBusQueue_maxMessageSizePremium
=== CONT  TestAccServiceBusQueue_maxMessageSizePremium
--- PASS: TestAccServiceBusQueue_maxMessageSizePremium (546.34s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/servicebus    548.029s

=== RUN   TestAccServiceBusTopic_maxMessageSizePremium
=== PAUSE TestAccServiceBusTopic_maxMessageSizePremium
=== CONT  TestAccServiceBusTopic_maxMessageSizePremium
--- PASS: TestAccServiceBusTopic_maxMessageSizePremium (655.72s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/servicebus    657.335s

[aristosvo]

Rebased and specific tests run again:

--- PASS: TestAccServiceBusTopic_maxMessageSizePremium (369.36s)
--- PASS: TestAccServiceBusQueue_maxMessageSizePremium (626.95s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/servicebus    628.530s

[katbyte]

Hmm, unfortunately looks like there are a lot of test failures for this PR:

------- Stdout: -------
=== RUN   TestAccServiceBusQueueAuthorizationRule_send
=== PAUSE TestAccServiceBusQueueAuthorizationRule_send
=== CONT  TestAccServiceBusQueueAuthorizationRule_send
    testcase.go:108: Step 1/2 error: Error running apply: exit status 1
        
        Error: servicebus.QueuesClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="BadRequest" Message="SubCode=40000. Bad Request. To know more visit https://aka.ms/sbResourceMgrExceptions. . TrackingId:e50426a6-400e-4c46-b0ad-c0f2339438b6_M8SN1_M8SN1_G23, SystemTracker:acctest-211021224411380471.servicebus.windows.net:acctest-211021224411380471, Timestamp:2021-10-21T22:46:02 CorrelationId: b9dc9446-28e1-ecab-b3ac-37b961b7246a"
        
          with azurerm_servicebus_queue.test,
          on terraform_plugin_test.tf line 18, in resource "azurerm_servicebus_queue" "test":
          18: resource "azurerm_servicebus_queue" "test" {
        
--- FAIL: TestAccServiceBusQueueAuthorizationRule_send (474.85s)
FAIL

[github-actions]

This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[aristosvo]

Oops, sorry! I didn't expect any return on the property in non-Premium SKU situations, which is apparently the case. This should solve it.

--- PASS: TestAccServiceBusTopic_update (331.45s)
--- PASS: TestAccServiceBusTopic_maxMessageSizePremium (357.12s)
--- PASS: TestAccServiceBusQueue_maxMessageSizePremium (360.29s)
--- PASS: TestAccServiceBusQueue_update (478.95s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/servicebus    480.451s

[katbyte]

Thanks @aristosvo - LGTM ⛏️

[github-actions]

This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.