Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mssql_db: add support for transparent data encryption #13748

Merged
merged 14 commits into from
Nov 29, 2021
Merged

mssql_db: add support for transparent data encryption #13748

merged 14 commits into from
Nov 29, 2021

Conversation

koikonom
Copy link
Contributor

TDE is enabled by default for some SKUs but not for others, so we cannot
just introduce this setting.

Since this is a breaking change the setting will be set behind a feature
flag.

@koikonom koikonom added this to the v2.82.0 milestone Oct 15, 2021
@koikonom koikonom added enhancement service/mssql Microsoft SQL Server labels Oct 15, 2021
@koikonom koikonom requested a review from a team October 15, 2021 08:25
@koikonom koikonom force-pushed the f/mssql_db_transparent_encryption branch from 146201f to c3c3e24 Compare October 15, 2021 10:49
katbyte
katbyte approved these changes Oct 18, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @koikonom - LGTM aside from adding it to the upgrade guide/docs with a link to the upgrade guide/ect? 🤔 or a todo to upgrade the docs in 3.0?

tombuildsstuff
tombuildsstuff reviewed Oct 20, 2021
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments in addition to @katbyte but otherwise LGTM 👍

internal/services/mssql/mssql_database_resource.go Outdated Show resolved Hide resolved
internal/services/mssql/mssql_database_resource.go Outdated Show resolved Hide resolved
internal/services/mssql/mssql_database_resource.go Outdated Show resolved Hide resolved
internal/services/mssql/mssql_database_resource_test.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff changed the title add support for transparent data encryption mssql_db: add support for transparent data encryption Oct 20, 2021
@katbyte katbyte modified the milestones: v2.82.0, v2.83.0 Oct 21, 2021
@hashicorp hashicorp deleted a comment from github-actions bot Oct 25, 2021
@katbyte katbyte modified the milestones: v2.83.0, v2.84.0 Oct 29, 2021
@katbyte katbyte modified the milestones: v2.84.0, v2.85.0, v2.86.0 Nov 5, 2021
tombuildsstuff
tombuildsstuff approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments inline but this is otherwise G2G 👍

internal/services/mssql/mssql_database_resource.go Outdated Show resolved Hide resolved
internal/services/mssql/mssql_database_resource.go Outdated Show resolved Hide resolved
internal/services/mssql/mssql_database_resource.go Show resolved Hide resolved
Kyriakos Oikonomakos and others added 6 commits November 18, 2021 19:47
add support for transparent data encryption
4ef899a 
TDE is enabled by default for some SKUs but not for others, so we cannot
just introduce this setting.

Since this is a breaking change the setting will be set behind a feature
flag.
replace switch with if
1ab14b0
let's not release 3.0 yet
a6cd1c6
@koikonom @tombuildsstuff
Apply suggestions from code review
ed91bcc 
Co-authored-by: Tom Harvey <[email protected]>
apply review feedback
0185752
fix whitespace
3ae7b6b
@koikonom koikonom force-pushed the f/mssql_db_transparent_encryption branch from ce55b82 to a187a34 Compare November 18, 2021 19:51
@github-actions github-actions bot added size/L and removed size/M labels Nov 18, 2021
@katbyte katbyte modified the milestones: v2.86.0, v2.87.0 Nov 19, 2021
@koikonom koikonom assigned tombuildsstuff and unassigned koikonom Nov 24, 2021
@jackofallops jackofallops modified the milestones: v2.87.0, v2.88.0 Nov 26, 2021
tombuildsstuff
tombuildsstuff approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment about the linting but otherwise 👍

internal/services/mssql/mssql_database_resource.go Show resolved Hide resolved
@koikonom koikonom merged commit a271dbb into main Nov 29, 2021
@koikonom koikonom deleted the f/mssql_db_transparent_encryption branch November 29, 2021 17:52
koikonom pushed a commit that referenced this pull request Nov 29, 2021
Update Changelog for #13748
3715c4b
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

This functionality has been released in v2.88.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 2, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@katbyte katbyte Awaiting requested review from katbyte

Assignees

@koikonom koikonom

Labels
enhancement service/mssql Microsoft SQL Server size/L
Projects
None yet
Milestone
v2.88.0
Development

Successfully merging this pull request may close these issues.
4 participants
@koikonom @tombuildsstuff @katbyte @jackofallops