Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/azurerm_security_center_workspace: Allow creation with Free pricing tier #13710

Merged
merged 7 commits into from
Oct 13, 2021

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Oct 12, 2021

azurerm_security_center_workspace is now allowed with pricing tier set to Free, so the limitation in the code is removed too.

@favoretti favoretti changed the title Favoretti/seccenter pricing r/azurerm_security_center_workspace: Allow creation with Free pricing tier Oct 12, 2021
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@favoretti Thanks for this update. The tier change is working for me although I'm seeing a post-apply diff. I'm also wondering if the combined test can now be gotten rid of since the pricing restriction doesn't apply any more?

=== CONT  TestAccSecurityCenter_pricingAndWorkspace/workspace/basic
    testcase.go:88: Step 1/3 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # azurerm_security_center_workspace.test will be updated in-place
          ~ resource "azurerm_security_center_workspace" "test" {
                id           = "/subscriptions/1a6092a6-137e-4025-9a7c-ef77f76f2c02/providers/Microsoft.Security/workspaceSettings/default"
              ~ workspace_id = "/subscriptions/1a6092a6-137e-4025-9a7c-ef77f76f2c02/resourceGroups/acctestrg-sc-211012234838472760/providers/Microsoft.OperationalInsights/workspaces/acctest-211012234838472760-1" -> "/subscriptions/1a6092a6-137e-4025-9a7c-ef77f76f2c02/resourceGroups/acctestRG-sc-211012234838472760/providers/Microsoft.OperationalInsights/workspaces/acctest-211012234838472760-1"
                # (1 unchanged attribute hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
        --- FAIL: TestAccSecurityCenter_pricingAndWorkspace/workspace/basic (121.55s)



FAIL

@favoretti
Copy link
Collaborator Author

@manicminer christ. Resourcegroup casing again.. 🤦🏻‍♂️

I'll split the tests again and see whether I can fix up acceptance tests.

Thanks for your review!

@github-actions github-actions bot added size/M and removed size/S labels Oct 13, 2021
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit 3ed83c3 into hashicorp:main Oct 13, 2021
mbfrahry added a commit that referenced this pull request Oct 13, 2021
@mbfrahry mbfrahry added this to the v2.81.0 milestone Oct 13, 2021
@github-actions
Copy link

This functionality has been released in v2.81.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants