Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nil check to fix #13646 #13689

Merged
merged 1 commit into from
Oct 12, 2021
Merged

add nil check to fix #13646 #13689

merged 1 commit into from
Oct 12, 2021

Conversation

lonegunmanb
Copy link
Contributor

Try to fix #13646 .

The failed test TestAccLogicAppWorkflow_integrationServiceEnvironment also failed on upstream's main branch, so this fix should be ok I guess.

=== RUN TestAccLogicAppWorkflow_empty
=== PAUSE TestAccLogicAppWorkflow_empty
=== CONT TestAccLogicAppWorkflow_empty
--- PASS: TestAccLogicAppWorkflow_empty (308.00s)
=== RUN TestAccLogicAppWorkflow_requiresImport
=== PAUSE TestAccLogicAppWorkflow_requiresImport
=== CONT TestAccLogicAppWorkflow_requiresImport
--- PASS: TestAccLogicAppWorkflow_requiresImport (279.67s)
=== RUN TestAccLogicAppWorkflow_tags
=== PAUSE TestAccLogicAppWorkflow_tags
=== CONT TestAccLogicAppWorkflow_tags
--- PASS: TestAccLogicAppWorkflow_tags (544.30s)
=== RUN TestAccLogicAppWorkflow_integrationAccount
=== PAUSE TestAccLogicAppWorkflow_integrationAccount
=== CONT TestAccLogicAppWorkflow_integrationAccount
--- PASS: TestAccLogicAppWorkflow_integrationAccount (847.01s)
=== RUN TestAccLogicAppWorkflow_parameters
=== PAUSE TestAccLogicAppWorkflow_parameters
=== CONT TestAccLogicAppWorkflow_parameters
--- PASS: TestAccLogicAppWorkflow_parameters (263.44s)
=== RUN TestAccLogicAppWorkflow_accessControl
=== PAUSE TestAccLogicAppWorkflow_accessControl
=== CONT TestAccLogicAppWorkflow_accessControl
--- PASS: TestAccLogicAppWorkflow_accessControl (435.17s)
=== RUN TestAccLogicAppWorkflow_integrationServiceEnvironment
=== PAUSE TestAccLogicAppWorkflow_integrationServiceEnvironment
=== CONT TestAccLogicAppWorkflow_integrationServiceEnvironment
testcase.go:88: Step 1/2 error: Error running apply: exit status 1

    Error: waiting for completion of Integration Service Environment "acctestRG-logic-211011124032403569" (Resource Group "acctestRG-logic-211011124032403569"): Code="IntegrationServiceEnvironmentVirtualNetworkConnectivityFailure" Message="The integration service environment 'acctestRG-logic-211011124032403569' provisioning failed because the required connectivity to and from the virtual network 'acctest-vnet-211011124032403569' for management and runtime operations could not be established. Please make sure all the required ports are open https://aka.ms/integration-service-environment#set-up-network-ports."
    
      with azurerm_integration_service_environment.test,
      on terraform_plugin_test.tf line 57, in resource "azurerm_integration_service_environment" "test":
      57: resource "azurerm_integration_service_environment" "test" {
    
testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
    
    Error: deleting Subnet: (Name "isesubnet2" / Virtual Network Name "acctest-vnet-211011124032403569" / Resource Group "acctestRG-logic-211011124032403569"): network.SubnetsClient#Delete: Failure sending request: StatusCode=0 -- Original Error: Code="InUseSubnetCannotBeDeleted" Message="Subnet isesubnet2 is in use by /subscriptions/c73bac49-6143-4da3-bbdd-2d8e09a178dc/resourceGroups/easia_45506_bbb367447f584d79a4cf91db2470f7a9/providers/Microsoft.Network/loadBalancers/easia-45506-479743803/frontendIPConfigurations/frontend and cannot be deleted. In order to delete the subnet, delete all the resources within the subnet. See aka.ms/deletesubnet." Details=[]
    
    
    Error: deleting Subnet: (Name "isesubnet3" / Virtual Network Name "acctest-vnet-211011124032403569" / Resource Group "acctestRG-logic-211011124032403569"): network.SubnetsClient#Delete: Failure sending request: StatusCode=0 -- Original Error: Code="InUseSubnetCannotBeDeleted" Message="Subnet isesubnet3 is in use by /subscriptions/cd3cfe23-a890-4a2d-b81b-49d9e764a7c1/providers/Microsoft.ApiManagement/service?vnetResourceGuid=00dc3e56-b804-47f6-abb2-cc851312017d&subnet=isesubnet3&api-version=2016-07-07 and cannot be deleted. In order to delete the subnet, delete all the resources within the subnet. See aka.ms/deletesubnet." Details=[]

--- FAIL: TestAccLogicAppWorkflow_integrationServiceEnvironment (1898.79s)

FAIL

Process finished with the exit code 1

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @lonegunmanb, LGTM 👍🏼

@stephybun stephybun merged commit 9c65178 into hashicorp:main Oct 12, 2021
stephybun added a commit that referenced this pull request Oct 12, 2021
@stephybun stephybun added this to the v2.81.0 milestone Oct 12, 2021
@github-actions
Copy link

This functionality has been released in v2.81.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2021
@lonegunmanb lonegunmanb deleted the f-13646 branch January 26, 2022 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_logic_app_workflow access_control empty bug
2 participants