Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_lb_nat_pool: Add support for floating_ip_enabled, tcp_reset_enabled, idle_timeout_in_minutes #13674

Merged
merged 5 commits into from
Oct 15, 2021

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Oct 9, 2021

TF_ACC=1 go test ./internal/services/loadbalancer/ -v -parallel 11 -test.run=TestAccAzureRMLoadBalancerNatPool_ -timeout 1440m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMLoadBalancerNatPool_basic
=== PAUSE TestAccAzureRMLoadBalancerNatPool_basic
=== RUN TestAccAzureRMLoadBalancerNatPool_complete
=== PAUSE TestAccAzureRMLoadBalancerNatPool_complete
=== RUN TestAccAzureRMLoadBalancerNatPool_update
=== PAUSE TestAccAzureRMLoadBalancerNatPool_update
=== RUN TestAccAzureRMLoadBalancerNatPool_requiresImport
=== PAUSE TestAccAzureRMLoadBalancerNatPool_requiresImport
=== RUN TestAccAzureRMLoadBalancerNatPool_disappears
=== PAUSE TestAccAzureRMLoadBalancerNatPool_disappears
=== RUN TestAccAzureRMLoadBalancerNatPool_updateMultiplePools
=== PAUSE TestAccAzureRMLoadBalancerNatPool_updateMultiplePools
=== CONT TestAccAzureRMLoadBalancerNatPool_basic
=== CONT TestAccAzureRMLoadBalancerNatPool_requiresImport
=== CONT TestAccAzureRMLoadBalancerNatPool_update
=== CONT TestAccAzureRMLoadBalancerNatPool_updateMultiplePools
=== CONT TestAccAzureRMLoadBalancerNatPool_complete
=== CONT TestAccAzureRMLoadBalancerNatPool_disappears
--- PASS: TestAccAzureRMLoadBalancerNatPool_complete (234.87s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_basic (303.70s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_requiresImport (308.64s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_disappears (321.32s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_updateMultiplePools (362.72s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_update (386.37s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/loadbalancer 386.711s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sinbai - overall looks good aside from some comments on schema which i've left inline

@@ -98,6 +98,23 @@ func resourceArmLoadBalancerNatPool() *pluginsdk.Resource {
ValidateFunc: validation.StringIsNotEmpty,
},

"enable_floating_ip": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually put enabled on the end

Suggested change
"enable_floating_ip": {
"floating_ip_enabled": {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Optional: true,
},

"enable_tcp_reset": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"enable_tcp_reset": {
"tcp_reset_enabled": {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinbai - looks good now aside from CI not passing

@katbyte katbyte modified the milestones: v2.81.0, v2.82.0 Oct 14, 2021
@sinbai sinbai force-pushed the loadbalancer/inbound_nat_pools branch from f88c15c to 1f353cf Compare October 15, 2021 02:27
@sinbai
Copy link
Contributor Author

sinbai commented Oct 15, 2021

Thanks @sinbai - looks good now aside from CI not passing

Fixed, thank you.

@katbyte katbyte changed the title azurerm_lb_nat_pool: Add support for enableFloatingIP, enableTcpReset , idleTimeoutInMinutes properties azurerm_lb_nat_pool: Add support for floating_ip_enabled, tcp_reset_enabled, idle_timeout_in_minutes Oct 15, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks @sinbai! LGTM 🍰

@katbyte katbyte merged commit a837208 into hashicorp:main Oct 15, 2021
katbyte added a commit that referenced this pull request Oct 15, 2021
@github-actions
Copy link

This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@sinbai sinbai deleted the loadbalancer/inbound_nat_pools branch October 22, 2021 00:33
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants