-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resource "azurerm_synapse_sql_pool_workload_group" #13658
new resource "azurerm_synapse_sql_pool_workload_group" #13658
Conversation
ms-henglu
commented
Oct 8, 2021
•
edited
Loading
edited
internal/services/synapse/synapse_sql_pool_workload_group_resource.go
Outdated
Show resolved
Hide resolved
internal/services/synapse/synapse_sql_pool_workload_group_resource.go
Outdated
Show resolved
Hide resolved
internal/services/synapse/synapse_sql_pool_workload_group_resource.go
Outdated
Show resolved
Hide resolved
Thanks @katbyte for code review. I've added a commit according to your suggestion, please take another look, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some test failures now:
------- Stdout: -------
=== RUN TestAccSynapseWorkloadGroup_update
=== PAUSE TestAccSynapseWorkloadGroup_update
=== CONT TestAccSynapseWorkloadGroup_update
testcase.go:110: Step 1/6 error: Error running pre-apply refresh: exit status 1
Error: expected type of min_resource_percent_per_request to be integer
with azurerm_synapse_sql_pool_workload_group.test,
on terraform_plugin_test.tf line 48, in resource "azurerm_synapse_sql_pool_workload_group" "test":
48: min_resource_percent_per_request = 3
--- FAIL: TestAccSynapseWorkloadGroup_update (3.99s)
FAIL
Hi @katbyte , I've updated. Please take another look. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ms-henglu - LGTM now 🏗️
This functionality has been released in v2.88.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |