Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource "azurerm_synapse_sql_pool_workload_group" #13658

Merged
merged 5 commits into from
Dec 1, 2021

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Oct 8, 2021

image

@katbyte katbyte modified the milestones: v2.84.0, v2.85.0 Nov 2, 2021
@katbyte katbyte modified the milestones: v2.85.0, v2.86.0 Nov 12, 2021
@katbyte katbyte modified the milestones: v2.86.0, v2.87.0 Nov 19, 2021
@ms-henglu
Copy link
Contributor Author

Thanks @katbyte for code review. I've added a commit according to your suggestion, please take another look, thanks!

@jackofallops jackofallops modified the milestones: v2.87.0, v2.88.0 Nov 26, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some test failures now:

------- Stdout: -------
=== RUN   TestAccSynapseWorkloadGroup_update
=== PAUSE TestAccSynapseWorkloadGroup_update
=== CONT  TestAccSynapseWorkloadGroup_update
    testcase.go:110: Step 1/6 error: Error running pre-apply refresh: exit status 1
        
        Error: expected type of min_resource_percent_per_request to be integer
        
          with azurerm_synapse_sql_pool_workload_group.test,
          on terraform_plugin_test.tf line 48, in resource "azurerm_synapse_sql_pool_workload_group" "test":
          48:   min_resource_percent_per_request = 3
        
--- FAIL: TestAccSynapseWorkloadGroup_update (3.99s)
FAIL

@ms-henglu
Copy link
Contributor Author

Hi @katbyte , I've updated. Please take another look. Thanks!

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - LGTM now 🏗️

@katbyte katbyte merged commit bfc7646 into hashicorp:main Dec 1, 2021
katbyte added a commit that referenced this pull request Dec 1, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

This functionality has been released in v2.88.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 2, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants