New resource: azurerm_data_factory_linked_service_cosmosdb_mongoapi
#13636
Conversation
There was a problem hiding this comment.
Thanks @favoretti, overall looks good and i just have 1 real comment about a property name
internal/services/datafactory/data_factory_linked_service_cosmosdb_mongoapi_resource.go
Outdated
Show resolved
Hide resolved
internal/services/datafactory/data_factory_linked_service_cosmosdb_mongoapi_resource.go
Outdated
Show resolved
Hide resolved
website/docs/r/data_factory_linked_service_cosmosdb_mongoapi.html.markdown
Show resolved
Hide resolved
There was a problem hiding this comment.
Hey @favoretti, since I recently finished refactoring all of the linked service resources (#13602) I decided to take a peek here. It would be helpful if you could use the custom importer and the id parser in this resource.
internal/services/datafactory/data_factory_linked_service_cosmosdb_mongoapi_resource.go
Outdated
Show resolved
Hide resolved
internal/services/datafactory/data_factory_linked_service_cosmosdb_mongoapi_resource.go
Outdated
Show resolved
Hide resolved
|
Thanks both. Property related to mongo version, i.e. 3.2 or higher. I'll rebase and use parsers and happy to rename property to whatever y'all seem feasible. |
|
how about |
Fixes hashicorp#8905 ``` $ TF_ACC=1 go test -v ./internal/services/datafactory -timeout=1000m -run='TestAccDataFactoryLinkedServiceCosmosDbMongoAPI' === RUN TestAccDataFactoryLinkedServiceCosmosDbMongoAPI_basic === PAUSE TestAccDataFactoryLinkedServiceCosmosDbMongoAPI_basic === RUN TestAccDataFactoryLinkedServiceCosmosDbMongoAPI_serverVersionAbove32 === PAUSE TestAccDataFactoryLinkedServiceCosmosDbMongoAPI_serverVersionAbove32 === RUN TestAccDataFactoryLinkedServiceCosmosDbMongoAPI_update === PAUSE TestAccDataFactoryLinkedServiceCosmosDbMongoAPI_update === CONT TestAccDataFactoryLinkedServiceCosmosDbMongoAPI_basic === CONT TestAccDataFactoryLinkedServiceCosmosDbMongoAPI_update === CONT TestAccDataFactoryLinkedServiceCosmosDbMongoAPI_serverVersionAbove32 --- PASS: TestAccDataFactoryLinkedServiceCosmosDbMongoAPI_serverVersionAbove32 (142.39s) --- PASS: TestAccDataFactoryLinkedServiceCosmosDbMongoAPI_basic (144.43s) --- PASS: TestAccDataFactoryLinkedServiceCosmosDbMongoAPI_update (189.73s) PASS ok github.com/hashicorp/terraform-provider-azurerm/internal/services/datafactory 191.256s ```
favoretti
force-pushed
the
favoretti/8905
branch
from
01e1299
to
baca0a9
Compare
|
|
There was a problem hiding this comment.
Thanks for making those changes @favoretti 🙂. Just another few teeny tiny remarks that need to be addressed then we're there!
internal/services/datafactory/data_factory_linked_service_cosmosdb_mongoapi_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/datafactory/data_factory_linked_service_cosmosdb_mongoapi_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/datafactory/data_factory_linked_service_cosmosdb_mongoapi_resource_test.go
Outdated
Show resolved
Hide resolved
website/docs/r/data_factory_linked_service_cosmosdb_mongoapi.html.markdown
Outdated
Show resolved
Hide resolved
|
@stephybun Sorry, should've checked these in IDE rather than blindly commit via GH. Thanks for fixing! |
There was a problem hiding this comment.
It was my mistake in the suggestion so that was on me 😅. Thanks for fixing up the rest of it @favoretti! LGTM 🚀
|
This functionality has been released in v2.81.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #8905