Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nil check to fix #12163 #13540

Merged
merged 4 commits into from
Oct 8, 2021
Merged

add nil check to fix #12163 #13540

merged 4 commits into from
Oct 8, 2021

Conversation

lonegunmanb
Copy link
Contributor

@lonegunmanb lonegunmanb commented Sep 29, 2021

As @tombuildsstuff pointed out the source of nil pointer, and the purpose of returning an nil pointer was to "de-associating" child subscription, not child resource mgr group, an extra nil check should be necessary and sufficient.
It should fix #12163

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @lonegunmanb. I have just one small suggestion, otherwise LGTM!

@stephybun stephybun merged commit 41b2a9a into hashicorp:main Oct 8, 2021
stephybun added a commit that referenced this pull request Oct 8, 2021
@stephybun stephybun added this to the v2.81.0 milestone Oct 8, 2021
@github-actions
Copy link

This functionality has been released in v2.81.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2021
@lonegunmanb lonegunmanb deleted the f-12163 branch January 26, 2022 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: The terraform-provider-azurerm_v2.62.1_x5.exe plugin crashed!
2 participants