azurerm_application_gateway - support priority property

[gingerninja80]

Fixes #13247

[tombuildsstuff]

hey @gingerninja80

Thanks for this PR.

I've taken a look through and besides one minor comment to the documentation this otherwise LGTM 👍

Thanks!

[katbyte]

Looks like we have a test failure:

------ Stdout: -------
=== RUN   TestAccApplicationGateway_requestRoutingRulePriority
=== PAUSE TestAccApplicationGateway_requestRoutingRulePriority
=== CONT  TestAccApplicationGateway_requestRoutingRulePriority
    testcase.go:88: Step 2/3 error: Error running apply: exit status 1
        
        Error: creating/updating Application Gateway: (Name "acctestag-211006184123439634" / Resource Group "acctestRG-211006184123439634"): network.ApplicationGatewaysClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="ApplicationGatewayRequestRoutingRulesUsingSameHttpListener" Message="Two Request Routing Rules of Application Gateway /subscriptions/*******/resourceGroups/acctestRG-211006184123439634/providers/Microsoft.Network/applicationGateways/acctestag-211006184123439634 are using the same Http Listener /subscriptions/*******/resourceGroups/acctestRG-211006184123439634/providers/Microsoft.Network/applicationGateways/acctestag-211006184123439634/httpListeners/acctest-vnet-211006184123439634-httplstn." Details=[]
        
          with azurerm_application_gateway.test,
          on terraform_plugin_test.tf line 53, in resource "azurerm_application_gateway" "test":
          53: resource "azurerm_application_gateway" "test" {
        
--- FAIL: TestAccApplicationGateway_requestRoutingRulePriority (814.40s)
FAIL

[gingerninja80]

@katbyte please can you re-test?

[katbyte]

Thanks @gingerninja80 ! tests pass now LGTM 🙌

[katbyte]

@gingerninja80 - just need GHA CI to be fixed and this is good to go!

[katbyte]

Was looking at this today and it seems there is a check with the wrong value?

------- Stdout: -------
=== RUN   TestAccApplicationGateway_requestRoutingRulePriority
=== PAUSE TestAccApplicationGateway_requestRoutingRulePriority
=== CONT  TestAccApplicationGateway_requestRoutingRulePriority
    testcase.go:88: Step 2/3 error: Check failed: Check 2/3 error: azurerm_application_gateway.test: Attribute 'request_routing_rule.0.priority' expected "1", got "0"
--- FAIL: TestAccApplicationGateway_requestRoutingRulePriority (866.40s)
FAIL

[github-actions]

This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[gingerninja80]

The issue highlighted by @katbyte have now been resolved and the acctests are all passing successfully, so I'm really hoping this will be included in the v2.83.0 release 🤞🏼

[katbyte]

Thanks @gingerninja80! they are now, LGTM 🏗️

[github-actions]

This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.