Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster: Set default upgrade channel to none on create #13493

Merged

Conversation

favoretti
Copy link
Collaborator

No description provided.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.79.0 milestone Sep 28, 2021
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2021-09-28 at 14 03 10

@tombuildsstuff tombuildsstuff merged commit 448fdd7 into hashicorp:main Sep 28, 2021
tombuildsstuff added a commit that referenced this pull request Sep 28, 2021
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

This functionality has been released in v2.79.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DanielHajduk2-TomTom
Copy link

Hi, Im using version: hashicorp/azurerm v2.79.0
And we still get:
"Feature Microsoft.ContainerService/AutoUpgradePreview is not enabled. Please see https://aka.ms/aks/previews for how to enable features."

When this parameter is not specified. Default value seems not to be None.

@sossickd
Copy link

sossickd commented Oct 2, 2021

Experiencing the same issue as of 2.79.0 when building AKS cluster.

"Feature Microsoft.ContainerService/AutoUpgradePreview is not enabled. Please see https://aka.ms/aks/previews for how to enable features."

katbyte pushed a commit that referenced this pull request Oct 3, 2021
This PR adds a information that the default value for the option automatic_channel_upgrade is now none if the option is not specified. Please see my comment here: #11396 (comment)

This was introduces in the Release 2.79.0with #13493.
@fcatacut
Copy link
Contributor

fcatacut commented Oct 4, 2021

I'd expect that defaulting to none should also allow you to explicitly set automatic_channel_upgrade = none. However, I get the following on terraform plan:

Error: expected automatic_channel_upgrade to be one of [patch rapid stable node-image], got none

@tombuildsstuff
Copy link
Contributor

@fcatacut you can specify none by omitting the field / setting this value to null

@Sanverik
Copy link

Sanverik commented Oct 4, 2021

@fcatacut you can specify none by omitting the field / setting this value to null

Original Error: Code="BadRequest" Message="Feature Microsoft.ContainerService/AutoUpgradePreview is not enabled.

I set automatic_channel_upgrade to null, but still have the same error

@Sanverik
Copy link

Sanverik commented Oct 4, 2021

The same situation when I am just omitting the field automatic_channel_upgrade

@paulgmiller
Copy link

paulgmiller commented Oct 7, 2021

Tryning to speak for aks. Think we've created some confusing here. @favoretti @tombuildsstuff None not actaully the default blank or unspecified is. This is because we're reserveing the right to change the default in the future but still let the customer opt out to none.

Azure/AKS#2584

@jotterson
Copy link

this does not work in 2.80 when automatic_channel_upgrade is set to null or "none" or "".

meaning I cannot create kubernetes cluster with the azurerm provider >= 2.79.

@fcatacut
Copy link
Contributor

this does not work in 2.80 when automatic_channel_upgrade is set to null or "none" or "".

meaning I cannot create kubernetes cluster with the azurerm provider >= 2.79.

@tombuildsstuff posted a message in the corresponding AKS issue: Azure/AKS#2584 (comment). For now, I'd suggest just pinning to 2.78. Hopefully, you don't need any new functionality or bug fixes that are available in a later version.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants