Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: backup_policy_file_share #13444

Merged
merged 3 commits into from
Oct 7, 2021
Merged

New data source: backup_policy_file_share #13444

merged 3 commits into from
Oct 7, 2021

Conversation

oWretch
Copy link
Contributor

@oWretch oWretch commented Sep 21, 2021

Add a data source to pull details of an existing File Share backup policy

@oWretch oWretch changed the title Add backup_policy_file_share data source New data source: backup_policy_file_share Sep 21, 2021
katbyte
katbyte previously requested changes Oct 6, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for he pr @oWretch - overall looks good but have a test failure:

------- Stdout: -------
=== RUN   TestAccDataSourceBackupPolicyFileShare_basic
=== PAUSE TestAccDataSourceBackupPolicyFileShare_basic
=== CONT  TestAccDataSourceBackupPolicyFileShare_basic
    testcase.go:88: Step 1/1 error: Error running pre-apply refresh: exit status 1
        
        Error: Invalid data source
        
          on terraform_plugin_test.tf line 39, in data "azurerm_backup_policy_file_share" "test":
          39: data "azurerm_backup_policy_file_share" "test" {
        
        The provider hashicorp/azurerm does not support data source
        "azurerm_backup_policy_file_share".
        
        Did you intend to use the managed resource type
        "azurerm_backup_policy_file_share"? If so, declare this using a "resource"
        block instead of a "data" block.
--- FAIL: TestAccDataSourceBackupPolicyFileShare_basic (2.75s)
FAIL

@katbyte katbyte added this to the v2.80.0 milestone Oct 6, 2021
@katbyte katbyte dismissed their stale review October 6, 2021 23:35

oh nm looks like you already fixed this since i ran the tests this morning!

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oWretch ! LGTM 🍰

@katbyte katbyte merged commit a7fc6d2 into hashicorp:main Oct 7, 2021
katbyte added a commit that referenced this pull request Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

This functionality has been released in v2.80.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants