Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_logic_app_integration_account_agreement #13287

Merged
merged 5 commits into from
Sep 10, 2021

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Sep 9, 2021

This PR is to add support for new resource Logic App Integration Account Agreement.

Although the content property is exact struct type, but I assume we should treat it as json string as a whole thing to allow users to set the agreement content what they want since it only stands for agreement content.

--- PASS: TestAccLogicAppIntegrationAccountAgreement_basic (296.25s)
--- PASS: TestAccLogicAppIntegrationAccountAgreement_complete (296.26s)
--- PASS: TestAccLogicAppIntegrationAccountAgreement_requiresImport (316.52s)
--- PASS: TestAccLogicAppIntegrationAccountAgreement_update (421.34s)

API Reference:
https://github.com/Azure/azure-rest-api-specs/blob/ceb6d11a85d834c838181a3031cd106d14a2d674/specification/logic/resource-manager/Microsoft.Logic/stable/2019-05-01/logic.json#L4918

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei - LGTM 🏗️

@katbyte
Copy link
Collaborator

katbyte commented Sep 9, 2021

just need merge conflicts resolved now

@katbyte katbyte merged commit 7a5deaf into hashicorp:main Sep 10, 2021
katbyte added a commit that referenced this pull request Sep 10, 2021
@github-actions
Copy link

This functionality has been released in v2.76.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants