Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/azurerm_kubernetes_cluster: Support local_account_disabled setup in data source #13260

Merged
merged 4 commits into from
Sep 8, 2021

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Sep 7, 2021

Fixes #13248

Acceptance Test

  • Test added for fixed/new functionality: TestAccDataSourceKubernetesCluster_localAccountDisabled
  • New test run:
❯ make acctests SERVICE='containers' TESTARGS='-run=TestAccDataSourceKubernetesCluster_localAccountDisabled'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/containers -run=TestAccDataSourceKubernetesCluster_localAccountDisabled -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceKubernetesCluster_localAccountDisabled
=== PAUSE TestAccDataSourceKubernetesCluster_localAccountDisabled
=== CONT  TestAccDataSourceKubernetesCluster_localAccountDisabled
--- PASS: TestAccDataSourceKubernetesCluster_localAccountDisabled (473.35s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers    474.821s

@aristosvo aristosvo changed the title azurerm_kubernetes_cluster: Support local_account_disabled setup in data source d/azurerm_kubernetes_cluster: Support local_account_disabled setup in data source Sep 7, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - couple minor comments and it looks like the test is failing:

------- Stdout: -------
=== RUN   TestAccDataSourceKubernetesCluster_localAccountDisabled
=== PAUSE TestAccDataSourceKubernetesCluster_localAccountDisabled
=== CONT  TestAccDataSourceKubernetesCluster_localAccountDisabled
    testcase.go:88: Step 1/1 error: Check failed: Check 8/8 error: data.azurerm_kubernetes_cluster.test: Attribute 'kube_admin_config_raw' found when not expected
--- FAIL: TestAccDataSourceKubernetesCluster_localAccountDisabled (532.56s)
FAIL

website/docs/d/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/d/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved
Aris van Ommeren added 2 commits September 7, 2021 21:22
@aristosvo
Copy link
Collaborator Author

aristosvo commented Sep 7, 2021

@katbyte Thanks for the quick review! Was already running (and fixing) locally, so I believe it is solved for now 👍🏽

❯ make acctests SERVICE='containers' TESTARGS='-run=TestAccDataSourceKubernetesCluster_localAccountDisabled'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/containers -run=TestAccDataSourceKubernetesCluster_localAccountDisabled -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceKubernetesCluster_localAccountDisabled
=== PAUSE TestAccDataSourceKubernetesCluster_localAccountDisabled
=== CONT  TestAccDataSourceKubernetesCluster_localAccountDisabled
--- PASS: TestAccDataSourceKubernetesCluster_localAccountDisabled (473.35s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers    474.821s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo! LGTM 🏗️

@katbyte katbyte merged commit 3a99c8b into hashicorp:main Sep 8, 2021
katbyte added a commit that referenced this pull request Sep 8, 2021
@github-actions
Copy link

This functionality has been released in v2.76.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Local Account disabled for AKS
2 participants