Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outbound_ip_addresses export to azurerm_app_service_slot #1317

Closed
perbergland opened this issue May 29, 2018 · 4 comments
Closed

Add outbound_ip_addresses export to azurerm_app_service_slot #1317

perbergland opened this issue May 29, 2018 · 4 comments

Comments

@perbergland
Copy link

perbergland commented May 29, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

azurerm_app_service_slot share many of the properties of azurerm_app_service.
One such export property that is currently missing is outbound_ip_addresses which can be used to set up firewall entries for resources like SQL server.

New or Affected Resource(s)

  • azurerm_app_service_slot

Potential Terraform Configuration

locals {
  warmup_outbound_ips      = "${sort(split(",",azurerm_app_service_slot.warmup.outbound_ip_addresses))}"
}

References

@tombuildsstuff
Copy link
Contributor

hey @perbergland

Thanks for opening this issue :)

From what I understand, the IP Addresses for an App Service Slot will be the same as the IP Addresses for an App Service - as such whilst we can add support for this; are you seeing a difference between the two?

Thanks!

@perbergland
Copy link
Author

Yeah well once I found out by experience that the outbound addresses change periodically and can take on any ip from that location (unless you cough up a lot of dough for ASE) the value of this output degraded significantly :(
But thanks for the swift reply

@perbergland
Copy link
Author

Hmmm maybe I was wrong - it does seem like the list of IP addresses given is static within a tier:
https://docs.microsoft.com/en-us/azure/app-service/app-service-ip-addresses#find-outbound-ips

regardless, if the slot has the same IP addresses as the app_service then that is enough.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants