Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/monitor: Various updates #13121

Merged
merged 11 commits into from
Aug 25, 2021
Merged

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Aug 24, 2021

  • Upgrade monitor package to 2021-07-01-preview
  • r/azurerm_monitor_autoscale_setting: Add divide_by_instance_count to metric_trigger
  • Fixed majority of the acceptance test failures

Fixes #7696

* Upgrade `monitor` package to `2021-07-01-preview`
* `r/azurerm_monitor_autoscale_setting`: Add `divide_by_instance_count` to `metric_trigger`
@favoretti favoretti changed the title `service/monitor: Various updates service/monitor: Various updates Aug 24, 2021
@favoretti
Copy link
Collaborator Author

image

As discussed, the last failing test is flaky and will potentially recover in a few hours.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @favoretti 👍

@tombuildsstuff tombuildsstuff added this to the v2.74.0 milestone Aug 25, 2021
@tombuildsstuff tombuildsstuff merged commit a44eea5 into hashicorp:main Aug 25, 2021
tombuildsstuff added a commit that referenced this pull request Aug 25, 2021
@github-actions
Copy link

This functionality has been released in v2.74.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for azurerm_monitor_autoscale_setting "metric divide by instance count"
2 participants