Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add appconfig key resource #13118

Merged
merged 20 commits into from
Sep 1, 2021
Merged

Add appconfig key resource #13118

merged 20 commits into from
Sep 1, 2021

Conversation

koikonom
Copy link
Contributor

This PR introduces a new resource, azurerm_appconfiguration_key, that is used to manage key/label pairs in an Application Configuration.

@koikonom koikonom requested a review from a team August 24, 2021 10:08
favoretti
favoretti suggested changes Aug 24, 2021
View reviewed changes
Copy link
Collaborator

@favoretti favoretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @koikonom, this is looking as a great start! Few minor comments inline.

website/docs/r/app_configuration_key.html.markdown Outdated Show resolved Hide resolved
website/docs/r/app_configuration_key.html.markdown Outdated Show resolved Hide resolved
website/docs/r/app_configuration_key.html.markdown Outdated Show resolved Hide resolved
website/docs/r/app_configuration_key.html.markdown Outdated Show resolved Hide resolved
website/docs/r/app_configuration_key.html.markdown Outdated Show resolved Hide resolved
website/docs/r/app_configuration_key.html.markdown Outdated Show resolved Hide resolved
website/docs/r/app_configuration_key.html.markdown Outdated Show resolved Hide resolved
website/docs/r/app_configuration_key.html.markdown Outdated Show resolved Hide resolved
internal/clients/builder.go Outdated Show resolved Hide resolved
internal/services/appconfiguration/app_configuration_key_resource.go Outdated Show resolved Hide resolved
@koikonom koikonom added this to the v2.74.0 milestone Aug 25, 2021
tombuildsstuff
tombuildsstuff suggested changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @koikonom

Thanks for this PR - I've taken a look through and left some comments inline - if we can fix those up then this should otherwise be good to go 👍

Thanks!

internal/services/appconfiguration/app_configuration_key_resource.go Show resolved Hide resolved
internal/services/appconfiguration/app_configuration_key_resource.go Outdated Show resolved Hide resolved
internal/services/appconfiguration/app_configuration_key_resource.go Outdated Show resolved Hide resolved
internal/services/appconfiguration/app_configuration_key_resource.go Outdated Show resolved Hide resolved
internal/services/appconfiguration/app_configuration_key_resource.go Outdated Show resolved Hide resolved
internal/services/appconfiguration/app_configuration_key_resource_test.go Outdated Show resolved Hide resolved
internal/services/appconfiguration/app_configuration_key_resource_test.go Show resolved Hide resolved
website/docs/r/app_configuration_key.html.markdown Outdated Show resolved Hide resolved
internal/services/appconfiguration/client/client.go Outdated Show resolved Hide resolved
internal/services/appconfiguration/client/client.go Outdated Show resolved Hide resolved
@katbyte katbyte modified the milestones: v2.74.0, v2.75.0 Aug 27, 2021
manicminer
manicminer approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @koikonom, just a couple suggestions around the Plugin SDK wrappers but this otherwise LGTM 👍

internal/services/appconfiguration/app_configuration_key_resource.go Outdated Show resolved Hide resolved
internal/services/appconfiguration/app_configuration_key_resource.go Show resolved Hide resolved
manicminer
manicminer suggested changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koikonom This mostly lgtm, I think the docs needs updating and more clarity on the differences when using the two types. I was also wondering if some of the properties are needed in all cases? (comments inline :)

internal/services/appconfiguration/app_configuration_key_resource.go Show resolved Hide resolved
internal/services/appconfiguration/app_configuration_key_resource.go Outdated Show resolved Hide resolved
manicminer
manicminer approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor comment but LGTM! 🧀

internal/services/appconfiguration/app_configuration_key_resource.go Show resolved Hide resolved
@koikonom koikonom merged commit 41900e2 into main Sep 1, 2021
@koikonom koikonom deleted the f/appconfig_kv branch September 1, 2021 15:59
koikonom pushed a commit that referenced this pull request Sep 1, 2021
Changelog update for #13118
851bc22
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This functionality has been released in v2.75.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 3, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@favoretti favoretti favoretti requested changes

@manicminer manicminer manicminer approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
documentation new-resource service/app-configuration size/XL
Projects
None yet
Milestone
v2.75.0
Development

Successfully merging this pull request may close these issues.
5 participants
@koikonom @manicminer @tombuildsstuff @favoretti @katbyte