Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add resource "azurerm_machine_learning_compute_instance" #12834

Merged
merged 3 commits into from
Aug 19, 2021
Merged

add resource "azurerm_machine_learning_compute_instance" #12834

merged 3 commits into from
Aug 19, 2021

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Aug 4, 2021 •
edited by katbyte
Loading

image

Though there's a failed test, it's not related to this new resource

(Fixes #6827)

@ms-henglu ms-henglu force-pushed the ticket-1859724-new-resource-ml-compute-instance branch 2 times, most recently from 9432d9a to be2a414 Compare August 4, 2021 06:53
katbyte
katbyte requested changes Aug 12, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - comments left inline

azurerm/internal/services/machinelearning/machine_learning_compute_instance_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/machinelearning/machine_learning_compute_instance_resource.go Outdated Show resolved Hide resolved
@ms-henglu ms-henglu force-pushed the ticket-1859724-new-resource-ml-compute-instance branch from 52148c9 to 835b9a2 Compare August 12, 2021 07:22
@ms-henglu ms-henglu requested a review from katbyte August 12, 2021 07:51
@ms-henglu
Copy link
Contributor Author

@katbyte , Hi, I've added a commit to rename fields as your suggestions, please take another look, thanks!

@katbyte katbyte added this to the v2.73.0 milestone Aug 12, 2021
@ms-henglu
Copy link
Contributor Author

@katbyte, Hi, commit updated, please take another look, thanks!

@ms-henglu ms-henglu force-pushed the ticket-1859724-new-resource-ml-compute-instance branch from 0e861c2 to 93e0955 Compare August 13, 2021 05:21
@ms-henglu ms-henglu force-pushed the ticket-1859724-new-resource-ml-compute-instance branch from 93e0955 to 8ce50fb Compare August 17, 2021 08:35
@ms-henglu
Copy link
Contributor Author

@katbyte , Hi, I've added a commit to rename fields as your suggestions and resolved conflicts, please take another look, thanks!

@ms-henglu ms-henglu requested a review from katbyte August 18, 2021 01:51
@favoretti
Copy link
Collaborator

Fixes #6827

katbyte
katbyte approved these changes Aug 19, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - LGTM 👍

@katbyte katbyte merged commit 83320c9 into hashicorp:main Aug 19, 2021
katbyte added a commit that referenced this pull request Aug 19, 2021
@katbyte
CHANGLOG.md for #12834
b2a3000
@github-actions
Copy link

This functionality has been released in v2.73.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@gro1m
Copy link
Contributor

gro1m commented Sep 1, 2021

Fixes #11255

@gro1m gro1m mentioned this pull request Sep 1, 2021
Closed
@github-actions
Copy link

github-actions bot commented Oct 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/machine-learning size/XL
Projects
None yet
Milestone
v2.73.0
Development

Successfully merging this pull request may close these issues.

Support for azureml compute
4 participants
@ms-henglu @favoretti @gro1m @katbyte